-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2916: Add tts on ios #3046
base: main
Are you sure you want to change the base?
2916: Add tts on ios #3046
Conversation
f66b907
to
a418449
Compare
I really tried to create a less "hacky" solution by introducing this "suppressEvent" function but to use it in all "manual" triggers like Also this ios issue that i linked is opened since ios15 (4years+) i don't expect that this will be fixed soonish tbh. |
…rate playNext function for manual trigger
39dd727
to
14f04b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that looks pretty ugly indeed, thank you for explaining at each step of the way why you were doing what, and for slogging through that mess! Tested on real iOS
When I realized what the issue is, i should have come to the conclusión to just remove the event listener and readd after stop. So I guess this PR is outdated and we should check Steffens. Sometimes i get lost in the woods 😁 |
Short description
Ios internally uses the wrong function for stop tts and is therefore sending the wrong Events and even twice.
I don't think we can do here anything, i already checked the native bindings if we could patch there something.
Therefore i added some tweaks here to workaround the event sending issues we have on ios.
Thats really not a clean way so feel free to provide a better solution
Proposed changes
Issues
Side effects
Testing
Resolved issues
Fixes: #2917