-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2917: Fix tts on ios proposal #3063
Conversation
912a403
to
5e2c7d2
Compare
return [] | ||
}, [model, languageCode]) | ||
const ttsContext = useContext(TtsContext) | ||
const [previousSentences] = useState(ttsContext.sentences) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find another way to ensure that the correct sentences are set after navigating back.
048f9f2
to
6f58f22
Compare
6f58f22
to
aaefb6c
Compare
aaefb6c
to
f19813a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. But looks good. 👍
Glad that you found a better solution :)
Tested on ios real device
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Tested on real iOS
Sorry I was late to check it out (tested on Andorid) |
Short description
This PR fixes tts on iOS and a few other bugs and problems with tts.
Furthermore, I added some tests and did some refactoring.
Proposed changes
TtsContainer
instead of header for clear responsibilitiesSide effects
N/A, hopefully everything works now on both android and ios.
Testing
Test the tts player thoroughly on both ios and android! Press all buttons multiple times (especially pause, play, previous, next) and navigate between different pages while the tts player is open.
Resolved issues
Fixes: #2917