Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pdf-service): remove font size changes in pdf form #1554

Merged
merged 4 commits into from
Dec 16, 2024
Merged

refactor(pdf-service): remove font size changes in pdf form #1554

merged 4 commits into from
Dec 16, 2024

Conversation

rbrtrfl
Copy link
Contributor

@rbrtrfl rbrtrfl commented Dec 16, 2024

  • remove the font size changes and checked for implications on all cases
  • change default font size for form fields to 10
  • move s.A. string to const (not exactly this scope, but the pr seems small enough)

chohner
chohner approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@chohner chohner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

app/services/pdf/pdf.server.ts Outdated Show resolved Hide resolved
app/services/pdf/pdf.server.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rbrtrfl rbrtrfl merged commit d64a9ec into main Dec 16, 2024
21 checks passed
@rbrtrfl rbrtrfl deleted the remove-font-size-changes-in-pdf-form branch December 16, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chohner chohner chohner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbrtrfl @chohner