Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JavaScript int literal overflow #1422

Merged
merged 4 commits into from
Sep 26, 2023
Merged

fix: JavaScript int literal overflow #1422

merged 4 commits into from
Sep 26, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Sep 17, 2023

Description

Fixes two more instances of the #1335 bug

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (72e2d41) 75.96% compared to head (9bbce38) 75.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1422   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files          75       75           
  Lines        3454     3454           
  Branches      554      554           
=======================================
  Hits         2624     2624           
  Misses        669      669           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's get this merged and released 🚢 🚀

@vinitkumar vinitkumar merged commit 8293ba1 into master Sep 26, 2023
47 checks passed
@vinitkumar vinitkumar deleted the fix/js-int-overflow branch September 26, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants