Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JavaScript int literal overflow #1422

Merged
merged 4 commits into from
Sep 26, 2023
Merged

fix: JavaScript int literal overflow #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b43c91e
Update directory_table_list.html
fsbraun Sep 17, 2023
04e2aea
Update CHANGELOG.rst
fsbraun Sep 17, 2023
62f021f
Update directory_thumbnail_list.html
fsbraun Sep 17, 2023
9bbce38
Merge branch 'master' into fix/js-int-overflow
fsbraun Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ CHANGELOG
unreleased
==========

* Fixed two more instances of javascript int overflow issue (#1335)
* fix: ensure uniqueness of icon admin url names

3.0.6 (2023-09-08)
Expand Down
4 changes: 2 additions & 2 deletions filer/templates/admin/filer/folder/directory_table_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
</td>
<td class="column-icon">
{% if is_popup and filer_admin_context.pick_file %}
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, {{ file.id|unlocalize }}, '{% file_icon_url file %}', '{{ file.label|escapejs }}', '{{ file.get_admin_change_url }}'); return false;"
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, '{{ file.id|unlocalize }}', '{% file_icon_url file %}', '{{ file.label|escapejs }}', '{{ file.get_admin_change_url }}'); return false;"
title="{% translate 'Select this file' %}">
{% elif has_change_permission %}
<a href="{{ file.get_admin_change_url }}{% filer_admin_context_url_params %}"
Expand All @@ -115,7 +115,7 @@
<div>
<strong>
{% if is_popup and filer_admin_context.pick_file %}
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, {{ file.id|unlocalize }}, '{% file_icon_url file %}', '{{ file.label|escapejs }}', '{{ file.get_admin_change_url }}'); return false;"
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, '{{ file.id|unlocalize }}', '{% file_icon_url file %}', '{{ file.label|escapejs }}', '{{ file.get_admin_change_url }}'); return false;"
title="{% translate 'Select this file' %}">
{% elif has_change_permission %}
<a href="{{ file.get_admin_change_url }}{% filer_admin_context_url_params %}"
Expand Down
4 changes: 2 additions & 2 deletions filer/templates/admin/filer/folder/directory_thumbnail_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
<div class="thumbnail-file-item-box">
<div class="item-thumbnail">
{% if is_popup and filer_admin_context.pick_file %}
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, {{ file.id|unlocalize }}, '{% file_icon_url file %}', '{{ file.label|escapejs }}'); return false;"
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, '{{ file.id|unlocalize }}', '{% file_icon_url file %}', '{{ file.label|escapejs }}'); return false;"
title="{% translate 'Select this file' %}">
{% elif has_change_permission %}
<a href="{{ file.get_admin_change_url }}{% filer_admin_context_url_params %}"
Expand All @@ -115,7 +115,7 @@
<div class="item-name">
<div>
{% if is_popup and filer_admin_context.pick_file %}
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, {{ file.id|unlocalize }}, '{% file_icon_url file %}', '{{ file.label|escapejs }}'); return false;"
<a href="#" onclick="opener.dismissRelatedImageLookupPopup(window, '{{ file.id|unlocalize }}', '{% file_icon_url file %}', '{{ file.label|escapejs }}'); return false;"
title="{% translate 'Select this file' %}">
{% elif has_change_permission %}
<a href="{{ file.get_admin_change_url }}{% filer_admin_context_url_params %}"
Expand Down
Loading