Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify import "type" as module #55

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

WillHannon-MCB
Copy link
Collaborator

We need to specify "type" as module so Node recognizes ESM-style imports.

@WillHannon-MCB
Copy link
Collaborator Author

@jbloom, that didn't fix it. Now we're getting the opposite error (that the other syntax isn't working).

I'll figure this out. I've run into similar errors before. The bizarre thing is that it's not causing issues with our other sites.

@WillHannon-MCB
Copy link
Collaborator Author

The solution was to bump Node to a more recent version (23.x) and rebuild the package-lock.json with npm install.

@jbloom
Copy link
Collaborator

jbloom commented Dec 10, 2024

Great that this fixed it. Just so I understand, @WillHannon-MCB, how did updating node in .github/workflows make it build a different package-lock.json. I didn't think that the former affected the latter's build.

@jbloom jbloom linked an issue Dec 10, 2024 that may be closed by this pull request
@jbloom jbloom merged commit c3b3a15 into main Dec 10, 2024
1 check passed
@jbloom jbloom deleted the fix-vitepress-deployment branch December 10, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem building VitePress homepage
2 participants