Fix warning about missing default codecs on first run #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix looks good to me, but then I'm not sure why this is currently working on other operating systems. I'll have some time to look at this briefly in the next day or 2. |
dpaulat
reviewed
Jun 7, 2024
|
The failure is due to a compatibility issue between Conan v1.x and the latest version of Visual Studio (1940/17.10). There isn't much appetite for the conan developers to fix this in v1.x, but there is a fix for v2.x. Merging despite the failure, to keep from holding this open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm packaging Supercell Wx for
NixOS/nixpkgs(see: NixOS/nixpkgs#316266) and I noticed that on first run I get a warning about missing default codecs, even though I have the codecs in question installed. The audio playback works fine in the application itself.This change fixed my issue and seems to align with the intent of the nearby comment.