Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about missing default codecs on first run #223

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Fix warning about missing default codecs on first run #223

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
088bd6a
Fix warning about missing default codecs on first run, when those cod…
aware70 Jun 5, 2024
8536bc5
Check for any Ogg support in audio setup, not just Vorbis
aware70 Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scwx-qt/source/scwx/qt/ui/setup/audio_codec_page.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ bool AudioCodecPage::IsRequired()
// Setup is required if codec errors are not ignored, and the default codecs
// are not supported
return (!ignoreCodecErrors &&
oggCodecs.contains(QMediaFormat::AudioCodec::Vorbis));
!oggCodecs.contains(QMediaFormat::AudioCodec::Vorbis));
aware70 marked this conversation as resolved.
Show resolved Hide resolved
}

} // namespace setup
Expand Down