Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run replication reg tests with epoll #4426

Merged
merged 17 commits into from
Jan 20, 2025
Merged

chore: run replication reg tests with epoll #4426

merged 17 commits into from
Jan 20, 2025

Conversation

kostasrim
Copy link
Contributor

Run replication regression tests with epoll (only Release mode for now)

Resolves #4402

@kostasrim kostasrim requested review from romange and adiholden January 8, 2025 10:50
@kostasrim
Copy link
Contributor Author

@@ -46,7 +49,14 @@ runs:
export DRAGONFLY_PATH="${GITHUB_WORKSPACE}/${{inputs.build-folder-name}}/${{inputs.dfly-executable}}"
export UBSAN_OPTIONS=print_stacktrace=1:halt_on_error=1 # to crash on errors

timeout 50m pytest -m "${{inputs.filter}}" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --log-cli-level=INFO || code=$?
if [[ "${{inputs.epoll}}" == 'true' ]]; then
# Run only replication tests with epoll
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not all regression tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind, I thought you wanted only the replication ones. Also we can run both debug and release (now I only run them in release)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we got failures https://github.com/dragonflydb/dragonfly/actions/runs/12669695232/job/35307742465 but I guess these are expected

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets run all regression tests not only replication.
Not sure they are expected to fail as Roman said he did some fixes. @romange do you want to check this or should we?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets skip ipv6 test for epoll. Please check why test_big_containers fail

build-type: [Debug, Release]
runner: [ubuntu-latest, [self-hosted, linux, ARM64]]
exclude:
- proactor: Epoll
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we exclude epoll with debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but we can add it

Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kostasrim
Copy link
Contributor Author

kostasrim commented Jan 17, 2025

@kostasrim kostasrim merged commit 85cc443 into main Jan 20, 2025
16 checks passed
@kostasrim kostasrim deleted the kpr2 branch January 20, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add coverage to replication with force_epoll
3 participants