-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: run replication reg tests with epoll #4426
Conversation
Signed-off-by: kostas <[email protected]>
@@ -46,7 +49,14 @@ runs: | |||
export DRAGONFLY_PATH="${GITHUB_WORKSPACE}/${{inputs.build-folder-name}}/${{inputs.dfly-executable}}" | |||
export UBSAN_OPTIONS=print_stacktrace=1:halt_on_error=1 # to crash on errors | |||
|
|||
timeout 50m pytest -m "${{inputs.filter}}" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --log-cli-level=INFO || code=$? | |||
if [[ "${{inputs.epoll}}" == 'true' ]]; then | |||
# Run only replication tests with epoll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not all regression tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind, I thought you wanted only the replication ones. Also we can run both debug and release
(now I only run them in release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we got failures https://github.com/dragonflydb/dragonfly/actions/runs/12669695232/job/35307742465 but I guess these are expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets run all regression tests not only replication.
Not sure they are expected to fail as Roman said he did some fixes. @romange do you want to check this or should we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets skip ipv6 test for epoll. Please check why test_big_containers fail
build-type: [Debug, Release] | ||
runner: [ubuntu-latest, [self-hosted, linux, ARM64]] | ||
exclude: | ||
- proactor: Epoll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we exclude epoll with debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but we can add it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Run replication regression tests with epoll (only Release mode for now)
Resolves #4402