-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1329 when already a fundingjson present propose editing it instead of creating #1386
Merged
mhgbrown
merged 24 commits into
main
from
mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating
Dec 12, 2024
Merged
1329 when already a fundingjson present propose editing it instead of creating #1386
mhgbrown
merged 24 commits into
main
from
mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating
Dec 12, 2024
+202
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚅 Previously deployed to Railway in the Drips App project. Environment has been deleted. |
mhgbrown
force-pushed
the
mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating
branch
from
December 6, 2024 13:05
efccb07
to
4bd1613
Compare
mhgbrown
force-pushed
the
mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating
branch
from
December 6, 2024 13:08
3b1dafe
to
4bd1613
Compare
mhgbrown
force-pushed
the
mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating
branch
from
December 9, 2024 13:00
7a81cd7
to
d8a6f45
Compare
mhgbrown
requested review from
efstajas and
jtourkos
and removed request for
efstajas
December 9, 2024 13:51
- Change codebox cta text when editing
efstajas
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
src/lib/flows/claim-project-flow/steps/enter-git-url/enter-git-url.ts
Outdated
Show resolved
Hide resolved
efstajas
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, meant to approve :D
mhgbrown
deleted the
mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating
branch
December 12, 2024 13:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accommodates
FUNDING.json
s that already have content during the claim process. If they have content, a "diff" is shown, demonstrating what to add to the file.