Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1329 when already a fundingjson present propose editing it instead of creating #1386

Conversation

mhgbrown
Copy link
Collaborator

@mhgbrown mhgbrown commented Dec 6, 2024

This PR accommodates FUNDING.jsons that already have content during the claim process. If they have content, a "diff" is shown, demonstrating what to add to the file.

Screenshot 2024-12-09 at 17 43 58

Copy link

railway-app bot commented Dec 6, 2024

🚅 Previously deployed to Railway in the Drips App project. Environment has been deleted.

@mhgbrown mhgbrown force-pushed the mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating branch from efccb07 to 4bd1613 Compare December 6, 2024 13:05
@mhgbrown mhgbrown force-pushed the mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating branch from 3b1dafe to 4bd1613 Compare December 6, 2024 13:08
@mhgbrown mhgbrown force-pushed the mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating branch from 7a81cd7 to d8a6f45 Compare December 9, 2024 13:00
@mhgbrown mhgbrown marked this pull request as ready for review December 9, 2024 13:51
@mhgbrown mhgbrown requested review from efstajas and jtourkos and removed request for efstajas December 9, 2024 13:51
- Change codebox cta text when editing
@mhgbrown mhgbrown marked this pull request as draft December 9, 2024 14:45
@mhgbrown mhgbrown marked this pull request as draft December 10, 2024 18:39
@mhgbrown mhgbrown marked this pull request as ready for review December 11, 2024 12:25
Copy link
Contributor

@efstajas efstajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@efstajas efstajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, meant to approve :D

@mhgbrown mhgbrown merged commit 08baafb into main Dec 12, 2024
5 checks passed
@mhgbrown mhgbrown deleted the mhgbrown-1329-when-already-a-fundingjson-present-propose-editing-it-instead-of-creating branch December 12, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When already a FUNDING.json present, propose editing it instead of creating
2 participants