Ev/iss629 streams #639
Merged
Ev/iss629 streams #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
efstajas
requested changes
Sep 5, 2023
| @@ -168,7 +168,6 @@ describe('app', async () => { | |||
| it('displays the original users outgoing stream on their profile', async () => { | |||
| await page.goto('http://127.0.0.1:3000/app/0x433220a86126eFe2b8C98a723E73eBAd2D0CbaDc'); | |||
|
|
|||
| await expect(page.locator('text=↑ Outgoing')).toHaveCount(1); | |||
There was a problem hiding this comment.
Removing this kinda removes the entire check that this new stream is being interpreted by the streams store as outgoing, rather than incoming. 😬 Would be good to keep that
There was a problem hiding this comment.
maybe just check that neither "incoming" or "outgoing" appear at this point. that should do it
There was a problem hiding this comment.
In 3f2ed36, I check for "From" and "Total streamed" since outgoing/incoming = 0 would be true in any situation without both stream types present
… mode style: layout incoming streams section first, only show incoming/outgoing headers if both types are present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streams section of #629
@efstajas, I can't assign brandon to review PRs?