Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: rmv 'funds' in Add modal (closes #719) #726

Merged
merged 2 commits into from
Oct 10, 2023
Merged

style: rmv 'funds' in Add modal (closes #719) #726

merged 2 commits into from
Oct 10, 2023

Conversation

evvvritt
Copy link
Collaborator

@evvvritt evvvritt commented Oct 9, 2023

closes #719

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for drips-app-v2 ready!

Name Link
🔨 Latest commit f0ee258
🔍 Latest deploy log https://app.netlify.com/sites/drips-app-v2/deploys/652400726e92ab0008f13df0
😎 Deploy Preview https://deploy-preview-726--drips-app-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@evvvritt evvvritt marked this pull request as ready for review October 9, 2023 13:33
@@ -100,7 +100,7 @@
<StepLayout>
<EmojiAndToken emoji="💰" tokenAddress={tokenInfo.info.address} animateTokenOnMount />
<StepHeader
headline={`Add ${tokenInfo?.info.symbol ?? ''} funds`}
headline={`Add ${tokenInfo?.info.symbol}`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we had a default '' value before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear to me, but the changes match what we have in Withdraw modal (no ' ' fallback)

@evvvritt evvvritt merged commit 441b4d5 into main Oct 10, 2023
9 checks passed
@evvvritt evvvritt deleted the ev/iss719 branch October 10, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Add USDC funds" Modal
2 participants