Require full IPv4 address string to be treated as valid URL #616
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
changed the title
This was referenced Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1206262563462715/f
iOS PR: duckduckgo/iOS#2298
macOS PR: duckduckgo/macos-browser#2012
What kind of version bump will this require?: Patch
Description:
When an IPv4-like string is passed to URL constructor, require that it contains 4 octets and otherwise return nil.
This allows clients to fall back to treating the string as search query and constructing search URLs, instead
of making most likely unwanted navigation to an IP address where missing octets are filled with zeros
(e.g. 1.4 -> 1.0.0.4).
Steps to test this PR:
1.4/3.4in the search bar.http://1.0.0.4/3.4.OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template