Allow calculations in the address bar #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
samsymons
added a commit
that referenced
this pull request
Jan 8, 2024
* main: deps BrowserServicesKit 100.0.3 + content-scope-scripts 4.59.0 (#2304) bookmarks migration refactor (#2236) respect system theme on launch (#2302) remove unused pixels (#2303) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2285) Update Sync End-to-End tests (#2300) Allow calculations in the address bar (#2298) Remove trailing space in unableToCreateRecoveryPDF error (#2297) Update errors (#2283) BSK update for autofill never prompt to save for site feature (#2280) Add timeouts to the alpha job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206262563462715/f
Description:
Treat strings like "1.4" in address bar as search queries, not as IPs (1.0.0.4).
Steps to test this PR:
See BSK PR for steps to test.
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template