Skip to content

fix(duckplayer): prevent valid video links from opening in a new tab #10451

fix(duckplayer): prevent valid video links from opening in a new tab

fix(duckplayer): prevent valid video links from opening in a new tab #10451

Triggered via pull request May 20, 2024 12:08
Status Success
Total duration 8m 53s
Billable time 28m
Artifacts

pr.yml

on: pull_request
Matrix: Test
SwiftLint
1m 3s
SwiftLint
Test Shell Scripts
23s
Test Shell Scripts
Make Release Build
5m 7s
Make Release Build
Verify autoconsent bundle
15s
Verify autoconsent bundle
ShellCheck
7s
ShellCheck
Private API Report  /  Update PR comment
3s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

37 warnings and 2 notices
Verify autoconsent bundle
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test Shell Scripts
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make Release Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox)
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): UnitTests/Tab/ViewModel/TabViewModelTests.swift#L297
variable 'tab' was never mutated; consider changing to 'let' constant
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGo Privacy Browser isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser' from project 'DuckDuckGo')
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test (Sandbox)
DuckDuckGoDBPBackgroundAgentAppStore isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgentAppStore' from project 'DuckDuckGo')
Test (Sandbox)
DuckDuckGo Privacy Browser App Store isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser App Store' from project 'DuckDuckGo')
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): UnitTests/Tab/ViewModel/TabViewModelTests.swift#L297
variable 'tab' was never mutated; consider changing to 'let' constant
Test (Sandbox): UnitTests/Tab/ViewModel/TabViewModelTests.swift#L297
variable 'tab' was never mutated; consider changing to 'let' constant
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Non-Sandbox)
Tests Passed: 0 failed, 0 skipped, 271 total (1.936 seconds)
Test (Sandbox)
Tests Passed: 0 failed, 0 skipped, 15 total (0.518 seconds)