-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Breakage Form #196
Open
mgurgel
wants to merge
18
commits into
main
Choose a base branch
from
mgurgel/improved-breakage-form
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ddgdash ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
2 times, most recently
from
November 8, 2024 11:02
56eeb1f
to
4fe8451
Compare
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
NPM npm i github:duckduckgo/privacy-dashboard#6bba70eb47225d4d42d934d512eb6301bc50ff6f Git submodule: git submodule update --remote --init submodules/privacy-dashboard
cd submodules/privacy-dashboard
git fetch origin
git checkout pr-releases/pr-227
git reset --hard origin/pr-releases/pr-227 Swift .package(url: "https://github.com/duckduckgo/privacy-dashboard", revision: "6bba70eb47225d4d42d934d512eb6301bc50ff6f"), |
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
2 times, most recently
from
November 14, 2024 19:39
9f3c6dc
to
bb5b905
Compare
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
November 19, 2024 14:11
778d5b5
to
978c26c
Compare
shakyShane
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to get the tests passing and the it's all good.
shared/js/ui/components/toggle-report/use-toggle-report-state.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Asana: https://app.asana.com/0/1206594217596623/1208618877312224/f
Description:
Steps to test this PR:
npm run preview