Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Breakage Form #196

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Improved Breakage Form #196

wants to merge 18 commits into from

Conversation

mgurgel
Copy link
Collaborator

@mgurgel mgurgel commented Oct 25, 2024

Reviewer:
Asana: https://app.asana.com/0/1206594217596623/1208618877312224/f

Description:

  • Improved breakage form flow
  • Toggle report data fetching for Android and Windows

Steps to test this PR:

  1. npm run preview
  2. Visit http://127.0.0.1:3220/html/iframe.html?screen=breakageForm&platforms=android%2Cios%2Cmacos%2Cwindows%2Cbrowser

@mgurgel mgurgel self-assigned this Oct 25, 2024
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for ddgdash ready!

Name Link
🔨 Latest commit f2346f2
🔍 Latest deploy log https://app.netlify.com/sites/ddgdash/deploys/674498c84ae26d00088bcb22
😎 Deploy Preview https://deploy-preview-196--ddgdash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mgurgel mgurgel force-pushed the mgurgel/improved-breakage-form branch 2 times, most recently from 56eeb1f to 4fe8451 Compare November 8, 2024 11:02
Copy link

github-actions bot commented Nov 8, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

NPM

npm i github:duckduckgo/privacy-dashboard#6bba70eb47225d4d42d934d512eb6301bc50ff6f

Git submodule:

git submodule update --remote --init submodules/privacy-dashboard
cd submodules/privacy-dashboard
git fetch origin
git checkout pr-releases/pr-227
git reset --hard origin/pr-releases/pr-227

Swift

.package(url: "https://github.com/duckduckgo/privacy-dashboard", revision: "6bba70eb47225d4d42d934d512eb6301bc50ff6f"),

@mgurgel mgurgel force-pushed the mgurgel/improved-breakage-form branch 2 times, most recently from 9f3c6dc to bb5b905 Compare November 14, 2024 19:39
@mgurgel mgurgel changed the title [WIP] Improved Breakage Form Improved Breakage Form Nov 18, 2024
@mgurgel mgurgel force-pushed the mgurgel/improved-breakage-form branch from 778d5b5 to 978c26c Compare November 19, 2024 14:11
Copy link
Collaborator

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to get the tests passing and the it's all good.

shared/js/ui/platform-features.mjs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants