feat(structured data) core endpoints to CRU rows
#2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fontanierh
force-pushed
the
feat/structure-data-core-endpoints-rows
branch
from
d824f31 to
9af8435
Compare
fontanierh
force-pushed
the
feat/structure-data-core-endpoints-rows
branch
from
9af8435 to
d8e455b
Compare
listing database rows
fontanierh
force-pushed
the
feat/structure-data-core-endpoints-rows
branch
from
d8e455b to
91ea7ea
Compare
fontanierh
changed the title
core endpoints to CRU rows
spolu
requested changes
Nov 10, 2023
| get(databases_rows_retrieve), | ||
| ) | ||
| .route( | ||
| "/projects/:project_id/data_sources/:data_source_id/databases/:database_id/rows", |
| struct DatabasesRowsListQuery { | ||
| offset: usize, | ||
| limit: usize, | ||
| table_id: Option<String>, |
There was a problem hiding this comment.
I think it's a bad design to fetch all at once. We never want to do something with 2 rows from different tables and can always parallelize
There was a problem hiding this comment.
We never want to do something with 2 rows
We kind of do when we generate the schema from scratch though, no ?
|
as per slack, merging and addressing comment in #2489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list, get and upsert DB rows
remaining code to complete #2210