Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement DB get schema (w/ endpoint) #2489

Merged
merged 7 commits into from
Nov 13, 2023
Merged

feat: implement DB get schema (w/ endpoint) #2489

merged 7 commits into from
Nov 13, 2023

Conversation

fontanierh
Copy link
Contributor

@fontanierh fontanierh commented Nov 10, 2023 •
edited
Loading

there's no schema "caching" yet, this is recomputing from scratch every call. The whole pre-building / caching stuff will be done separately (once we get everything working without it)

implementation for #2212

spolu
spolu requested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we would be storing / updating the schema in DB ?

The schema functions should be create / update with row (which can error if there is something incompatible) no?

core/bin/dust_api.rs Show resolved Hide resolved
core/bin/dust_api.rs Outdated Show resolved Hide resolved
core/src/databases/database.rs Outdated Show resolved Hide resolved
core/src/databases/database.rs Show resolved Hide resolved
core/src/databases/database.rs Outdated Show resolved Hide resolved
core/src/stores/postgres.rs Outdated Show resolved Hide resolved
@fontanierh fontanierh mentioned this pull request Nov 10, 2023
Merged
Base automatically changed from feat/structure-data-core-endpoints-rows to main November 10, 2023 15:23
@fontanierh fontanierh requested a review from spolu November 10, 2023 17:04
@fontanierh fontanierh mentioned this pull request Nov 13, 2023
Merged
spolu
spolu requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small code styling change. Otheriwse LGTM feel free to merge once addressed 👍

core/src/stores/postgres.rs Outdated Show resolved Hide resolved
core/src/stores/postgres.rs Outdated Show resolved Hide resolved
core/src/databases/database.rs Outdated Show resolved Hide resolved
core/src/databases/database.rs Outdated Show resolved Hide resolved
@fontanierh fontanierh merged commit 8d0af84 into main Nov 13, 2023
1 check passed
@fontanierh fontanierh deleted the feat/get-db-schema branch November 13, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolu spolu spolu requested changes

@philipperolet philipperolet Awaiting requested review from philipperolet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fontanierh @spolu