Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dust-apps: more stability + observability #4577

Merged
merged 2 commits into from
Apr 4, 2024
Merged

dust-apps: more stability + observability #4577

merged 2 commits into from
Apr 4, 2024

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Apr 4, 2024

Description

  • bump eventsource-client library version in core
  • Remove streaming retries, as they make no sense (unless streamed_retryable is true for specific errors (mostly thought trough early on for OpenAI but not others)
  • Add observatiliby on the Error streaming chunks to get a better understanding of where they come from

Risk

N/A

Deploy Plan

  • deploy front
  • deploy core

@spolu spolu requested a review from fontanierh April 4, 2024 16:18
@spolu
Copy link
Contributor Author

spolu commented Apr 4, 2024

PMRR

@spolu spolu merged commit c6ad5b1 into main Apr 4, 2024
5 checks passed
@spolu spolu deleted the spolu-more_core_stability branch April 4, 2024 16:22
fontanierh
fontanierh reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

flvndvd pushed a commit that referenced this pull request May 26, 2024
@spolu @flvndvd
dust-apps: more stability + observability (#4577)
9c0f397 
* dust-apps: more stability + observability

* remove streaming retries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fontanierh fontanierh fontanierh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spolu @fontanierh