Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate table name to 32 characters #4580

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Truncate table name to 32 characters #4580

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7daa064
Truncate table name to 32 characters
flvndvd Apr 4, 2024
e8f505f
Use 64
flvndvd Apr 4, 2024
f04e9c9
Revert "Use 64"
flvndvd Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion types/src/shared/utils/structured_data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ export function makeStructuredDataTableName(name: string, externalId: string) {
const lowercasedExternalId = externalId.toLowerCase();
const externalIdPrefix = lowercasedExternalId.substring(0, 4);
const externalIdSuffix = lowercasedExternalId.slice(-4);
return slugify(`${name}_${externalIdPrefix}_${externalIdSuffix}`);

const truncatedName = name.substring(0, 32);

return slugify(`${truncatedName}_${externalIdPrefix}_${externalIdSuffix}`);
}

export class InvalidStructuredDataHeaderError extends Error {}
Expand Down
Loading