Truncate table name to 32 characters #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e8f505f.
fontanierh
approved these changes
Apr 4, 2024
spolu
approved these changes
Apr 4, 2024
flvndvd
added a commit
that referenced
this pull request
May 26, 2024
* Truncate table name to 32 characters * Use 64 * Revert "Use 64" This reverts commit e8f505f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR truncates table names to a maximum of 32 characters, as we've encountered instances where the name of some Google Spreadsheets exceeded 8k+ characters. Although the Dust app relies on the table name, all application-side uses the tableId. I've run some queries on our database and found that no Dust apps are currently using database blocks with table names longer than 32 characters. Therefore, it should be safe to deploy this change.
Risk
Deploy Plan