[front] fix(csv) - csv parsing #9121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
reviewed
Dec 4, 2024
front/lib/api/tables.ts
Outdated
| for await (const anyRecord of parser) { | ||
| if (i++ >= rowIndex) { | ||
| const record = anyRecord as string[]; | ||
| for (const [i, h] of header.entries()) { | ||
| try { | ||
| valuesByCol[h] ??= []; | ||
| (valuesByCol[h] as string[]).push(record[i] || ""); | ||
| (valuesByCol[h] as string[]).push(record[i] ?? ""); |
There was a problem hiding this comment.
What types of value are we going to get that we didn't get? Are they desirable?
There was a problem hiding this comment.
this change is preemptive and not related to the fix, here if we get a value of 0 in record[i] it gets converted to ""
| @@ -369,14 +369,14 @@ export async function rowsFromCsv({ | |||
|
|
|||
| let i = 0; | |||
| const parser = parse(csv, { delimiter }); | |||
| const valuesByCol: Record<string, string[]> = {}; | |||
| const valuesByCol: Record<string, string[]> = Object.create(null); | |||
There was a problem hiding this comment.
Can you explain a bit more? :)
There was a problem hiding this comment.
mb completely forgot
There was a problem hiding this comment.
here it was {}["constructor"] that caused the issue
There was a problem hiding this comment.
There was a problem hiding this comment.
@spolu added a comment in code to explain the Object.create(null)
spolu
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
values[h]is a function: https://app.datadoghq.eu/logs?query=%40dd.env%3Aprod%20%22Error%20parsing%20record%22[…]=stream&from_ts=1733318910000&to_ts=1733318920000&live=falseonString.nullandundefined).> {}["constructor"] [Function: Object]Tested with:
Risk
Low.
Deploy Plan