Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] fix(csv) - csv parsing #9121

Merged
merged 8 commits into from
Dec 4, 2024
Merged

[front] fix(csv) - csv parsing #9121

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f7aec55
fix: handle falsey but non null values correctly
aubin-tchoi Dec 4, 2024
10961ff
refactor: initialize the values once for all to simplify
aubin-tchoi Dec 4, 2024
129f936
add a toString
aubin-tchoi Dec 4, 2024
9419f9a
Revert "add a toString"
aubin-tchoi Dec 4, 2024
eac6335
Revert "refactor: initialize the values once for all to simplify"
aubin-tchoi Dec 4, 2024
6022300
fix clashes occuring when some header values are method names
aubin-tchoi Dec 4, 2024
825cf7f
add a comment
aubin-tchoi Dec 4, 2024
83c6b89
remove redundant type cast and add a toString
aubin-tchoi Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions front/lib/api/tables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,14 +369,14 @@ export async function rowsFromCsv({

let i = 0;
const parser = parse(csv, { delimiter });
const valuesByCol: Record<string, string[]> = {};
const valuesByCol: Record<string, string[]> = Object.create(null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit more? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb completely forgot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it was {}["constructor"] that caused the issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://app.datadoghq.eu/logs?query=%22Error%20uploading%20table%20to%20Dust.%22&agg_m=count&agg_m_source=base&agg_t=count&cols=host%2Cservice&fromUser=true&messageDisplay=inline&refresh_mode=paused&storage=hot&stream_sort=desc&viz=stream&from_ts=1733319867925&to_ts=1733319925679&live=false

Copy link
Contributor Author

@aubin-tchoi aubin-tchoi Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spolu added a comment in code to explain the Object.create(null)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

for await (const anyRecord of parser) {
if (i++ >= rowIndex) {
const record = anyRecord as string[];
for (const [i, h] of header.entries()) {
try {
valuesByCol[h] ??= [];
(valuesByCol[h] as string[]).push(record[i] || "");
(valuesByCol[h] as string[]).push(record[i] ?? "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What types of value are we going to get that we didn't get? Are they desirable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is preemptive and not related to the fix, here if we get a value of 0 in record[i] it gets converted to ""

} catch (e) {
logger.error(
// temporary log to fix the valuesByCol[h].push is not a function error
Expand Down
Loading