Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt for the win - Wave #1 #9164

Merged
merged 5 commits into from
Dec 5, 2024
Merged

BigInt for the win - Wave #1 #9164

merged 5 commits into from
Dec 5, 2024

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Dec 5, 2024

Description

This PR finalizes the migration of primary and foreign keys from integers to BigInt in our front database (see production's script here.

It introduces:

  • A new BaseModel class that automatically sets id column as BigInt
  • Renaming of User model to UserModel
  • Local migration script for the schema changes

All models in the front database have already been migrated to BigInt. This PR simply re-aligns our codebase with this schema by introducing proper model abstractions and type definitions.

Risk

Deploy Plan

There are no migrations needed to be run.

@flvndvd flvndvd marked this pull request as ready for review December 5, 2024 17:17
Copy link

github-actions bot commented Dec 5, 2024

Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against 296e949

Copy link
Contributor

@aubin-tchoi aubin-tchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@flvndvd flvndvd added the migration-ack 📁 Label to acknowledge that a migration is required. label Dec 5, 2024
@flvndvd flvndvd merged commit 2812b3d into main Dec 5, 2024
8 checks passed
@flvndvd flvndvd deleted the flav/bigint-ftw branch December 5, 2024 19:35
@flvndvd flvndvd mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants