[front] Give access to all groups for system key #9401
Merged
+11
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tdraier
added
the
documentation-ack
spolu
approved these changes
Dec 16, 2024
spolu
reviewed
Dec 16, 2024
| @@ -129,10 +129,6 @@ export class GroupResource extends BaseResource<GroupModel> { | |||
| if (key.isSystem) { | |||
| whereCondition = { | |||
| ...whereCondition, | |||
| [Op.or]: [ | |||
There was a problem hiding this comment.
Actually not sure I understand the diff here can you explain a bit more?
There was a problem hiding this comment.
I'm removing the constraint on kind, so that we get all groups of the workspace, not only system or global
There was a problem hiding this comment.
Can you fix/update the comment above 🙏
tdraier
changed the title
tdraier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This revert the previous quick fix ( granting document post for system key ) and instead grant all groups access to system key authenticator, not just only system and global groups. This allows system key to be able to read/write documents into any space.
Risk
Deploy Plan
deploy front