-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20998] Record data in SQL #144
base: main
Are you sure you want to change the base?
Conversation
dcc9f62
to
53d0e2a
Compare
ab73b8d
to
a9c882c
Compare
aca9425
to
8deea2e
Compare
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
…figuration Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
|
||
// Open a new file to write the remaining data. | ||
// Throw an exception if the file cannot be opened. | ||
open_new_file_nts_(min_file_size + e.data_size_to_write()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This callback will be invoked during both MCAP and SQL recordings if disk is full. I believe it should have distinct implementations in McapWriter and SqlWriter. In the case of SQL, it is unnecessary to open a new file when the disk is full, as you can simply delete the beginning of the file.
void deserialize( | ||
const fastdds::dds::DynamicType::_ref_type& dynamic_type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deserialize
should be included in the Serializator
class
Signed-off-by: tempate <[email protected]>
8a4b377
to
e048a87
Compare
Code improvements:
Serializer
to serialize and deserializeTopicQoS
,TypeObjects
,TypeIdentifiers
, andDynamicTypes
.time_utils
to convert between different time formats.DdsRecorder
and theDdsReplayer
agnostic of the output format.McapLogErrorTest
to improve its readability.Configuration improvements:
cleanup-period
andmax-pending-samples
fromspecs
torecorder
.safety-margin
toresource-limits
.safety-margin
as a string (100MB, 128GiB, etc).Bug fixes:
assert
in ROS 2 topics.Potential TODOs: