Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20722] Update docs to force unlimited ResourceLimits if lower or equal to zero (backport #738) #742

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 4, 2024

Description

This PR updates documentation regarding resource limits (see attached PR)

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #738 done by [Mergify](https://mergify.com).

…ro (#738)

Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 495f5a2)

# Conflicts:
#	docs/fastdds/dds_layer/core/policy/standardQosPolicies.rst
@mergify mergify bot added the conflicts label Apr 4, 2024
Copy link
Author

mergify bot commented Apr 4, 2024

Cherry-pick of 495f5a2 has failed:

On branch mergify/bp/2.6.x/pr-738
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit 495f5a2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/fastdds/xml_configuration/common.rst

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/fastdds/dds_layer/core/policy/standardQosPolicies.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@Mario-DL
Copy link
Member

@richiprosima please test docs

1 similar comment
@Mario-DL
Copy link
Member

@richiprosima please test docs

@Mario-DL
Copy link
Member

@JesusPoderoso there were some warnings in the tests that we would need to address, would you mind taking a look at this ?

@Mario-DL Mario-DL modified the milestones: v2.6.8, v2.6.9 Apr 23, 2024
@Mario-DL
Copy link
Member

Closing this PR as we decide not to go on with the implementation.

@Mario-DL Mario-DL closed this May 16, 2024
@mergify mergify bot deleted the mergify/bp/2.6.x/pr-738 branch May 16, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants