-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22280] Add documentation for preferred_key_agreement
property (backport #963)
#967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #19921. Add new `preferred_key_agreement` property to auth plugin section. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add new `preferred_key_agreement` property to property policies section. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add new `preferred_key_agreement` property to snippets. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Fix doc8. Signed-off-by: Miguel Company <[email protected]> * Refs #22280. Apply suggestion. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 2f51e7c)
8 tasks
Signed-off-by: Miguel Company <[email protected]>
Mario-DL
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 3.0.x 2.14.x 2.10.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Nov 29, 2024
* Add documentation for `preferred_key_agreement` property (#963) * Refs #19921. Add new `preferred_key_agreement` property to auth plugin section. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add new `preferred_key_agreement` property to property policies section. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add new `preferred_key_agreement` property to snippets. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Fix doc8. Signed-off-by: Miguel Company <[email protected]> * Refs #22280. Apply suggestion. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 2f51e7c) * Change default value to `DH`. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 949a673)
Open
8 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 29, 2024
* Add documentation for `preferred_key_agreement` property (#963) * Refs #19921. Add new `preferred_key_agreement` property to auth plugin section. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add new `preferred_key_agreement` property to property policies section. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add new `preferred_key_agreement` property to snippets. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Fix doc8. Signed-off-by: Miguel Company <[email protected]> * Refs #22280. Apply suggestion. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 2f51e7c) * Change default value to `DH`. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 949a673)
Open
8 tasks
mergify bot
added a commit
that referenced
this pull request
Nov 29, 2024
* Add documentation for `preferred_key_agreement` property (#963) * Refs #19921. Add new `preferred_key_agreement` property to auth plugin section. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add new `preferred_key_agreement` property to property policies section. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add new `preferred_key_agreement` property to snippets. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Fix doc8. Signed-off-by: Miguel Company <[email protected]> * Refs #22280. Apply suggestion. Signed-off-by: Miguel Company <[email protected]> * Refs #19921. Add `AUTO` value to new option. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 2f51e7c) * Change default value to `DH`. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 949a673)
Open
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds documentation for the new property allowing the selection of the preferred key agreement algorithm.
@Mergifyio backport 3.1.x
We will backport to 3.1.x, but leaving the default value of the new property to the old behavior.
We will then backport from there into 3.0.x 2.14.x 2.10.x
Related implementation PR:
Contributor Checklist
Reviewer Checklist
This is an automatic backport of pull request #963 done by [Mergify](https://mergify.com).