Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22280] Add documentation for preferred_key_agreement property (backport #963) #967

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 28, 2024

Description

This adds documentation for the new property allowing the selection of the preferred key agreement algorithm.

@Mergifyio backport 3.1.x

We will backport to 3.1.x, but leaving the default value of the new property to the old behavior.
We will then backport from there into 3.0.x 2.14.x 2.10.x

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

This is an automatic backport of pull request #963 done by [Mergify](https://mergify.com).

* Refs #19921. Add new `preferred_key_agreement` property to auth plugin section.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add new `preferred_key_agreement` property to property policies section.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add new `preferred_key_agreement` property to snippets.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Fix doc8.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22280. Apply suggestion.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add `AUTO` value to new option.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 2f51e7c)
Signed-off-by: Miguel Company <[email protected]>
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany
Copy link
Member

@Mergifyio backport 3.0.x 2.14.x 2.10.x

Copy link
Author

mergify bot commented Nov 29, 2024

@MiguelCompany MiguelCompany merged commit 949a673 into 3.1.x Nov 29, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.1.x/pr-963 branch November 29, 2024 06:40
mergify bot added a commit that referenced this pull request Nov 29, 2024
* Add documentation for `preferred_key_agreement` property (#963)

* Refs #19921. Add new `preferred_key_agreement` property to auth plugin section.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add new `preferred_key_agreement` property to property policies section.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add new `preferred_key_agreement` property to snippets.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Fix doc8.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22280. Apply suggestion.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add `AUTO` value to new option.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 2f51e7c)

* Change default value to `DH`.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit 949a673)
mergify bot added a commit that referenced this pull request Nov 29, 2024
* Add documentation for `preferred_key_agreement` property (#963)

* Refs #19921. Add new `preferred_key_agreement` property to auth plugin section.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add new `preferred_key_agreement` property to property policies section.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add new `preferred_key_agreement` property to snippets.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Fix doc8.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22280. Apply suggestion.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add `AUTO` value to new option.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 2f51e7c)

* Change default value to `DH`.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit 949a673)
mergify bot added a commit that referenced this pull request Nov 29, 2024
* Add documentation for `preferred_key_agreement` property (#963)

* Refs #19921. Add new `preferred_key_agreement` property to auth plugin section.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add new `preferred_key_agreement` property to property policies section.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add new `preferred_key_agreement` property to snippets.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Fix doc8.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22280. Apply suggestion.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19921. Add `AUTO` value to new option.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 2f51e7c)

* Change default value to `DH`.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
(cherry picked from commit 949a673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants