Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins #974

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins #974

merged 3 commits into from
Dec 11, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Dec 11, 2024 •
edited by Mario-DL
Loading

Description

This PR adds documentation for the new properties added in eProsima/Fast-DDS#5450

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Dec 11, 2024
@MiguelCompany MiguelCompany mentioned this pull request Dec 11, 2024
Merged
15 tasks
@MiguelCompany @Mario-DL
Apply suggestions from code review
2f87bca 
Co-authored-by: Mario Domínguez López <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Mario-DL
Mario-DL approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Mario-DL
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

@mergify Mergify
Copy link

mergify bot commented Dec 11, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit cc95496 into master Dec 11, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/19925 branch December 11, 2024 15:20
This was referenced Dec 11, 2024
Open
Merged
Open
mergify bot pushed a commit that referenced this pull request Dec 11, 2024
@MiguelCompany @mergify
Document new transmit_algorithms_as_legacy on builtin security plug…
1affe8e 
…ins (#974)

* Refs #19925. Add documentation of new property in PKIDH.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19925. Add documentation of new property in Permissions.

Signed-off-by: Miguel Company <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mario Domínguez López <[email protected]>
Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit cc95496)

# Conflicts:
#	docs/fastdds/property_policies/security.rst
#	docs/fastdds/security/auth_plugin/auth_plugin.rst
mergify bot pushed a commit that referenced this pull request Dec 11, 2024
@MiguelCompany @mergify
Document new transmit_algorithms_as_legacy on builtin security plug…
58b4d30 
…ins (#974)

* Refs #19925. Add documentation of new property in PKIDH.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19925. Add documentation of new property in Permissions.

Signed-off-by: Miguel Company <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mario Domínguez López <[email protected]>
Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit cc95496)

# Conflicts:
#	code/DDSCodeTester.cpp
#	code/XMLTester.xml
#	docs/fastdds/property_policies/security.rst
#	docs/fastdds/security/auth_plugin/auth_plugin.rst
This was referenced Dec 11, 2024
Merged
Open
Open
mergify bot pushed a commit that referenced this pull request Dec 11, 2024
@MiguelCompany @mergify
Document new transmit_algorithms_as_legacy on builtin security plug…
e8be423 
…ins (#974)

* Refs #19925. Add documentation of new property in PKIDH.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19925. Add documentation of new property in Permissions.

Signed-off-by: Miguel Company <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mario Domínguez López <[email protected]>
Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit cc95496)

# Conflicts:
#	code/DDSCodeTester.cpp
#	code/XMLTester.xml
#	docs/fastdds/property_policies/security.rst
#	docs/fastdds/security/auth_plugin/auth_plugin.rst
mergify bot pushed a commit that referenced this pull request Dec 11, 2024
@MiguelCompany @mergify
Document new transmit_algorithms_as_legacy on builtin security plug…
df00d39 
…ins (#974)

* Refs #19925. Add documentation of new property in PKIDH.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19925. Add documentation of new property in Permissions.

Signed-off-by: Miguel Company <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mario Domínguez López <[email protected]>
Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit cc95496)

# Conflicts:
#	code/DDSCodeTester.cpp
#	code/XMLTester.xml
#	docs/fastdds/property_policies/security.rst
#	docs/fastdds/security/auth_plugin/auth_plugin.rst
This was referenced Dec 11, 2024
Open
Open
MiguelCompany added a commit that referenced this pull request Dec 13, 2024
@mergify @MiguelCompany
Document new transmit_algorithms_as_legacy on builtin security plug…
f51a0de 
…ins (#974) (#975)

* Document new `transmit_algorithms_as_legacy` on builtin security plugins (#974)

* Refs #19925. Add documentation of new property in PKIDH.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19925. Add documentation of new property in Permissions.

Signed-off-by: Miguel Company <[email protected]>

* Apply suggestions from code review

Co-authored-by: Mario Domínguez López <[email protected]>
Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
(cherry picked from commit cc95496)

# Conflicts:
#	docs/fastdds/property_policies/security.rst
#	docs/fastdds/security/auth_plugin/auth_plugin.rst

* Fix conflicts.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @Mario-DL