Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22353] Document new transmit_algorithms_as_legacy on builtin security plugins (backport #974) #978

Open
wants to merge 1 commit into
base: 2.10.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions code/DDSCodeTester.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,15 @@ void dds_domain_examples()
pqos.properties().properties().emplace_back(
"dds.sec.auth.builtin.PKI-DH.password",
"domainParticipantPassword");
<<<<<<< HEAD
=======
pqos.properties().properties().emplace_back(
"dds.sec.auth.builtin.PKI-DH.preferred_key_agreement",
"ECDH");
pqos.properties().properties().emplace_back(
"dds.sec.auth.builtin.PKI-DH.transmit_algorithms_as_legacy",
"true");
>>>>>>> cc95496 (Document new `transmit_algorithms_as_legacy` on builtin security plugins (#974))
//!--
}
{
Expand Down Expand Up @@ -623,6 +632,9 @@ void dds_domain_examples()
pqos.properties().properties().emplace_back(
"dds.sec.access.builtin.Access-Permissions.permissions",
"file://certs/permissions.smime");
pqos.properties().properties().emplace_back(
"dds.sec.access.builtin.Access-Permissions.transmit_algorithms_as_legacy",
"true");
//!--
}
{
Expand Down
15 changes: 15 additions & 0 deletions code/XMLTester.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2641,6 +2641,17 @@
<name>dds.sec.auth.builtin.PKI-DH.password</name>
<value>domainParticipantPassword</value>
</property>
<<<<<<< HEAD
=======
<property>
<name>dds.sec.auth.builtin.PKI-DH.preferred_key_agreement</name>
<value>ECDH</value>
</property>
<property>
<name>dds.sec.auth.builtin.PKI-DH.transmit_algorithms_as_legacy</name>
<value>true</value>
</property>
>>>>>>> cc95496 (Document new `transmit_algorithms_as_legacy` on builtin security plugins (#974))
</properties>
</propertiesPolicy>
</rtps>
Expand Down Expand Up @@ -2693,6 +2704,10 @@
<name>dds.sec.access.builtin.Access-Permissions.permissions</name>
<value>file://permissions.smime</value>
</property>
<property>
<name>dds.sec.access.builtin.Access-Permissions.transmit_algorithms_as_legacy</name>
<value>true</value>
</property>
</properties>
</propertiesPolicy>
</rtps>
Expand Down
13 changes: 13 additions & 0 deletions docs/fastdds/property_policies/security.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,19 @@ The following table outlines the properties used for the :ref:`DDS\:Auth\:PKI-DH
If the *password* property is not present, then the value supplied in the |br|
*private_key* property must contain the decrypted private key. |br|
The *password* property is ignored if the *private_key* is given in PKCS#11 scheme.
<<<<<<< HEAD
=======
* - ``preferred_key_agreement`` *(optional)*
- The preferred algorithm to use for generating the session's shared secret |br|
at the end of the authentication phase. Supported values are: |br|
a) ``DH``, ``DH+MODP-2048-256`` for Diffie-Hellman Ephemeral with 2048-bit MODP Group parameters. |br|
b) ``ECDH``, ``ECDH+prime256v1-CEUM`` for Elliptic Curve Diffie-Hellman Ephemeral with the NIST P-256 curve. |br|
c) ``AUTO`` for selecting the key agreement based on the signature algorithm in the Identity CA's certificate. |br|
Will default to ``AUTO`` if the property is not present.
* - ``transmit_algorithms_as_legacy`` *(optional)*
- Whether to transmit algorithm identifiers in non-standard legacy format. |br|
Will default to ``false`` if the property is not present.
>>>>>>> cc95496 (Document new `transmit_algorithms_as_legacy` on builtin security plugins (#974))

.. note::
All properties listed above have the ``dds.sec.auth.builtin.PKI-DH."`` prefix.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ The following table outlines the properties used for the DDS\:Access\:Permission
* - permissions
- URI to the Participant permissions document signed by the |br| Permissions CA in S/MIME format. |br|
Supported URI schemes: file.
* - transmit_algorithms_as_legacy *(optional)*
- Whether to transmit algorithm identifiers in non-standard legacy format. |br|
Will default to ``false`` if the property is not present.

.. note::
All listed properties have "dds.sec.access.builtin.Access-Permissions." prefix.
Expand Down
13 changes: 13 additions & 0 deletions docs/fastdds/security/auth_plugin/auth_plugin.rst
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,19 @@ The following table outlines the properties used for the DDS:\Auth\:PKI-DH plugi
If the *password* property is not present, then the value supplied in the |br|
*private_key* property must contain the decrypted private key. |br|
The *password* property is ignored if the *private_key* is given in PKCS#11 scheme.
<<<<<<< HEAD
=======
* - preferred_key_agreement *(optional)*
- The preferred algorithm to use for generating the session's shared secret |br|
at the end of the authentication phase. Supported values are: |br|
a) ``DH``, ``DH+MODP-2048-256`` for Diffie-Hellman Ephemeral with 2048-bit MODP Group parameters. |br|
b) ``ECDH``, ``ECDH+prime256v1-CEUM`` for Elliptic Curve Diffie-Hellman Ephemeral with the NIST P-256 curve. |br|
c) ``AUTO`` for selecting the key agreement based on the signature algorithm in the Identity CA's certificate. |br|
Will default to ``AUTO`` if the property is not present.
* - transmit_algorithms_as_legacy *(optional)*
- Whether to transmit algorithm identifiers in non-standard legacy format. |br|
Will default to ``false`` if the property is not present.
>>>>>>> cc95496 (Document new `transmit_algorithms_as_legacy` on builtin security plugins (#974))

.. note::
All listed properties have "dds.sec.auth.builtin.PKI-DH." prefix.
Expand Down