Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-sharing with security incompatiblity warning #979

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Add data-sharing with security incompatiblity warning #979

merged 2 commits into from
Dec 13, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Dec 13, 2024 •
edited by Mario-DL
Loading

Description

Add missing data-sharing with security incompatiblity warning, both in security and data sharing sections.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

Mario-DL
Mario-DL requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clarification. Just a NIT.
We would need to backport this to 3.1.x, 3.0.x, 2.14.x, 2.10.x and 2.6.x

docs/fastdds/transport/datasharing.rst Outdated Show resolved Hide resolved
@juanlofer-eprosima
Apply suggestion
d692d30 
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@Mario-DL Mario-DL added this to the v3.2.0 milestone Dec 13, 2024
Mario-DL
Mario-DL approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@juanlofer-eprosima juanlofer-eprosima merged commit de52248 into master Dec 13, 2024
4 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the hotfix/datasharing-security-warning branch December 13, 2024 11:40
@Mario-DL
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Dec 13, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@juanlofer-eprosima @mergify
Add data-sharing with security incompatiblity warning (#979)
ca113e6 
* Add data-sharing with security incompatiblity warning

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* Apply suggestion

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Juan Lopez Fernandez <[email protected]>
(cherry picked from commit de52248)
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@juanlofer-eprosima @mergify
Add data-sharing with security incompatiblity warning (#979)
b169441 
* Add data-sharing with security incompatiblity warning

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* Apply suggestion

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Juan Lopez Fernandez <[email protected]>
(cherry picked from commit de52248)
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@juanlofer-eprosima @mergify
Add data-sharing with security incompatiblity warning (#979)
071f02f 
* Add data-sharing with security incompatiblity warning

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* Apply suggestion

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Juan Lopez Fernandez <[email protected]>
(cherry picked from commit de52248)
This was referenced Dec 13, 2024
Merged
Open
Open
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@juanlofer-eprosima @mergify
Add data-sharing with security incompatiblity warning (#979)
6eef611 
* Add data-sharing with security incompatiblity warning

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* Apply suggestion

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Juan Lopez Fernandez <[email protected]>
(cherry picked from commit de52248)
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@juanlofer-eprosima @mergify
Add data-sharing with security incompatiblity warning (#979)
c4d5d77 
* Add data-sharing with security incompatiblity warning

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* Apply suggestion

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Juan Lopez Fernandez <[email protected]>
(cherry picked from commit de52248)
This was referenced Dec 13, 2024
Open
Open
fujitatomoya
fujitatomoya reviewed Dec 13, 2024
View reviewed changes
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanlofer-eprosima thanks for the quick response! appreciate that.

MiguelCompany pushed a commit that referenced this pull request Dec 17, 2024
@mergify @juanlofer-eprosima
Add data-sharing with security incompatiblity warning (#979) (#980)
87fd32f 
* Add data-sharing with security incompatiblity warning

Signed-off-by: Juan Lopez Fernandez <[email protected]>

* Apply suggestion

Signed-off-by: Juan Lopez Fernandez <[email protected]>

---------

Signed-off-by: Juan Lopez Fernandez <[email protected]>
(cherry picked from commit de52248)

Co-authored-by: juanlofer-eprosima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@juanlofer-eprosima @Mario-DL @fujitatomoya