Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19308] Add tab view in chart layout #192

Merged
merged 11 commits into from
Sep 6, 2023
Merged

Conversation

JesusPoderoso
Copy link
Contributor

This PR introduces a tab bar with tab management in the chart layout. It would be necessary to allow multiple views of different data representation, as charts, graphs....
That is the reason why the PR is pointing an intermediate branch which would contain the remain views too. The intermediary QML component TabLayout has been introduced between Panels and ChartsLayout components.

TabLayout features:

  • Add new tab. Each new tab displays (just for now) chart view option (previous default view) and topic view (unsupported)
  • Delete tab. Removes the tab and all the internal components.

TabLayout design decisions to be discussed in this PR:

  • If there is only one tab opened, it cannot be closed.
  • Maximum of 6 simultaneous tabs opened.

Possible Tab desired features to be implemented (and discussed in this PR too):

  • Reorder tabs by dragging them through the tab bar (as in a web browser)
  • Support multiple and simultaneous chart views. That would require to include a Chart View identifier through all code to identify which Chart View does data belong to.

@JesusPoderoso JesusPoderoso self-assigned this Aug 23, 2023
@JesusPoderoso JesusPoderoso temporarily deployed to codecov August 23, 2023 11:04 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov August 23, 2023 11:04 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov August 24, 2023 11:58 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov August 24, 2023 11:58 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov August 24, 2023 11:58 — with GitHub Actions Inactive
@JesusPoderoso
Copy link
Contributor Author

JesusPoderoso commented Aug 25, 2023

  • If there is only one tab opened, it cannot be closed.

It was agreed in an internal discussion to display the "default" tab if the last tab is closed.

  • Maximum of 6 simultaneous tabs opened.

Found visual bug while app window resized, which improved tabs behaviour when resizing window and when multiple tabs are added. Max tabs allowed number has been increased up to 15.

  • Reorder tabs by dragging them through the tab bar (as in a web browser)
  • Support multiple and simultaneous chart views. That would require to include a Chart View identifier through all code to identify which Chart View does data belong to.

Perhaps this features would be implemented in future PRs.

Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the following issues during review:

  • When resizing the app and closing a tab appears the following error and the monitor app freezes. This seems to come from wrapping text inside a layout.
    qrc:/qml/TabLayout.qml:55:5: QML Row: Row called polish() inside updatePolish() of Row
    qrc:/qml/TabLayout.qml:55:5: QML Row: possible QQuickItem::polish() loop
  • The visible layout within the tab keeps visible is the tab is removed and there are no tabs before that one. In order to reproduce it, crate a chart view, then add another tab, switch to chart view tab and then close it.
  • Window resize does not work. In order to reproduce it, create a chart view, then resize the monitor window and the internal box does not fit the parent element.

@JesusPoderoso JesusPoderoso temporarily deployed to codecov August 31, 2023 12:58 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov August 31, 2023 12:58 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov August 31, 2023 12:58 — with GitHub Actions Inactive
@JesusPoderoso
Copy link
Contributor Author

Previous two commits fix rev suggestions:

  • The visible layout within the tab keeps visible is the tab is removed and there are no tabs before that one. In order to reproduce it, crate a chart view, then add another tab, switch to chart view tab and then close it.

This is fixed in commit f5cd918

  • Window resize does not work. In order to reproduce it, create a chart view, then resize the monitor window and the internal box does not fit the parent element.

This is partially fixed in commit 14832e8. Currently it display a stdout warning with the following information: StackView has detected conflicting anchors. Transitions may not execute properly. This is caused because the ChartsLayout has been defined as a base and reusable component in the view. In future PR that would change, so multiple ChartsLayout can be opened, with different charts displayed in each one. That change will avoid the stdout message as ChartsLayout component will no longer be a reusable component.

@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 1, 2023 12:32 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 1, 2023 12:32 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 1, 2023 12:32 — with GitHub Actions Inactive
Signed-off-by: JesusPoderoso <[email protected]>
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 4, 2023 07:49 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 4, 2023 07:49 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 4, 2023 10:18 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 4, 2023 10:18 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 4, 2023 10:18 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 5, 2023 12:58 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 5, 2023 12:58 — with GitHub Actions Inactive
@JesusPoderoso JesusPoderoso temporarily deployed to codecov September 5, 2023 12:58 — with GitHub Actions Inactive
Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit ccaa137 into feature/graph_views Sep 6, 2023
7 checks passed
@rsanchez15 rsanchez15 deleted the feature/tabs branch September 6, 2023 05:05
JesusPoderoso added a commit that referenced this pull request Sep 20, 2023
* Refs #19308: Add tab view in chart layout

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Update graph view name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Close last tab would open New tab

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Add and delete tab buttons improvements

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix transition

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Cap max tabs to 15

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix view issue when first tab gets closed

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix ChartLayout view issue when resizing window

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix polish infinite loop

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Avoid tab dragging

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Propagate fullScreen var changes

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
JesusPoderoso added a commit that referenced this pull request Oct 24, 2023
* Refs #19308: Add tab view in chart layout

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Update graph view name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Close last tab would open New tab

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Add and delete tab buttons improvements

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix transition

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Cap max tabs to 15

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix view issue when first tab gets closed

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix ChartLayout view issue when resizing window

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix polish infinite loop

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Avoid tab dragging

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Propagate fullScreen var changes

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
JesusPoderoso added a commit that referenced this pull request Dec 12, 2023
* Refs #19308: Add tab view in chart layout

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Update graph view name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Close last tab would open New tab

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Add and delete tab buttons improvements

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix transition

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Cap max tabs to 15

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix view issue when first tab gets closed

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix ChartLayout view issue when resizing window

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix polish infinite loop

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Avoid tab dragging

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Propagate fullScreen var changes

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
JesusPoderoso added a commit that referenced this pull request Dec 12, 2023
* Refs #19308: Add tab view in chart layout

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Update graph view name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Close last tab would open New tab

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Add and delete tab buttons improvements

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix transition

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Cap max tabs to 15

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix view issue when first tab gets closed

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix ChartLayout view issue when resizing window

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix polish infinite loop

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Avoid tab dragging

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Propagate fullScreen var changes

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
JesusPoderoso added a commit that referenced this pull request Dec 12, 2023
* Refs #19308: Add tab view in chart layout

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Update graph view name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Close last tab would open New tab

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Add and delete tab buttons improvements

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix transition

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Cap max tabs to 15

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix view issue when first tab gets closed

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix ChartLayout view issue when resizing window

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix polish infinite loop

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Avoid tab dragging

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Propagate fullScreen var changes

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
rsanchez15 added a commit that referenced this pull request Dec 21, 2023
* Initial empty commit

Signed-off-by: JesusPoderoso <[email protected]>

* Add tab view in chart layout (#192)

* Refs #19308: Add tab view in chart layout

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Update graph view name

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Close last tab would open New tab

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Add and delete tab buttons improvements

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix transition

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Cap max tabs to 15

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix view issue when first tab gets closed

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix ChartLayout view issue when resizing window

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Fix polish infinite loop

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Avoid tab dragging

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19308: Propagate fullScreen var changes

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>

* Domain graph view implementation (#200)

* Disable dragging elements out of their bounds

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: Implement domain graph view

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Improve domain view

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Adapt to new JSON and visual improvements

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Add arrows to connections

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Round elements

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix entities height

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Update tab name with view content

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix connections

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Add domain id selector for graph view

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Add Refresh button and refresh feature

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: Implement Monitor <---> Backend connection

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Establish connection

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Add try-catch in SyncBackendConnection call

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Catch Exception when no graph

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: Fix issues, visual bugs and improvements

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix communication arrows visual bugs

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix icons and text spacing in entity boxes

Signed-off-by: JesusPoderoso <[email protected]>

Refs: Remove vulcanexus blue from color palette

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix entity order generation to optimize resizing

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Add comments to QML code

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Improve backend calls

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix overlapping visual bugs

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix resizing with large alias

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix single topic (and no entities) data representation

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Fix tab issue with multiple domains

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Display domain info when navigating through different domain views in tabs

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19308: Display entity and topic data when clicked in the graph

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19513: Improve Domain ID Dialog values

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19513: Add metatraffic filter in the graph view

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Improve arrow drawing

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: Please linters

Signed-off-by: JesusPoderoso <[email protected]>

* Initial empty commit

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecessary include

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecessary eol ';'

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove 'magic numbers'

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19532: [ARS] Remove wheel displacement 'magic number'

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Simplify hidden scrollbar

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecesary item

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Update status comparision to uppercase

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecessary width conditions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecessary filling rect

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Fix comment

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecessary recursive call

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Fix refresh domain info call

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecessary stack anchoring

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecessary 'z' ordering

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19532: [ARS] Remove unnecessary 'z' ordering

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: [ARS] Remove unnecessary load model calls

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: Reorder elements to fix tabs overlapping

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19532: Fix warning displayed when showing metatraffic

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: [ARS] Add parenthesys to conditional assignations

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: [ARS] Add error check in missing entities

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: [ARS] Remove unnecessary rect

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: [ARS] Add missing space

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: [ARS] Improve entities width management

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: Fix connections

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve comparasion conditions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Run resize call only once

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve connection generation

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Remove unnecessary load model call

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Reduce amount of painting iterations

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Fix typo

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Remove unnecessary signal declaration

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Apply latest rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>

* Status layout with problems per entity (#204)

* Refs #19533: Add Status view to layout

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Include problem callback backend connection

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Sync with statistics backend to obtain StatusData

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Take the samples and prepare a json structure

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Display the problem data in status layout

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Improve arrows based on internal feedback

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Include external QMLTreeView module

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Include external QMLTreeView module and adapt the tree with the required mechanisms

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Adapt model to use roles

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Include missing information through roles in the UI

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Add status icon and homogenize fonts

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Add incompatible qos policies links to documentation compatibility rules

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Fix first click issue in status footer and remove dead code

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Add view problem filter functionality

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Display entity issues counter on its right

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Avoid problem model destruction to avoid error messages when app closed

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Catch entity dispose and remove entity problems from model

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Update icons

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Fix visual details

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Fix error counting

Signed-off-by: JesusPoderoso <[email protected]>

Refs #19533: Adapt changes

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: Improve disable view of chart layout button

Signed-off-by: JesusPoderoso <[email protected]>

* Fix mock build issue

Signed-off-by: JesusPoderoso <[email protected]>

* Fix visual details

Signed-off-by: JesusPoderoso <[email protected]>

* Display entity information when clicked in status layout

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: Fix warning visual issue

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19533: Add filter to status layout properly

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Fix topic filtering visual bugs

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Add load model check for empty filter

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Set Backend status references

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Delete debug comment

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Rename all problems to statuses

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve comments

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Minor sugestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve entity status assignments

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Add missing problem sample 'Liveliness changed'

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve error / warning counter update and update left panel info when problem reported

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Rename method

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] QML minor changes

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve graph connections section

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Fix style in the imported qml files

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Remove unnecessary dead code

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Remove unnecessary method

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Refactor tree model filtering

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Remove info dead code

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve StatusLayout.qml comments

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve pointers deletion

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Refactor model roles to use direct get methods

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ALRS] Rename 'copy' model method as 'filtered_copy'

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ALRS] Remove repeated description in problems

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ALRS] Rename domain graph public property entity id as 'domain_entity_id'

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ALRS] Improve status counter anchoring to avoid overlapping numbers and icons

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ALRS] Improve status sample kind usage

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ALRS] Treat entity status model status as StatusLevel instead of as boolean

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ALRS] Comment typo

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Improve entity info update when new status reported

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Remove unnecessary error check

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Get Status Level string from sources (backend)

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Fix visual bug with expand/collapse status layout icon

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Fix timer flow

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Add try-catch in get_status_data

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Fix timer

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: [ARS] Fix left panel focus

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>

* Domain graph & status layout documentation (#205)

* Refs #19743: Update documentation sections to include tabs, domain graph and status problems

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Include new images

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Update screenshots

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19743: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>

* Improve graph visual details (#209)

* Refs #19973: Fix topic lines below entities visual bug

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Update Warning Icon to be more visible

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Remove info panel refresh call when new status is reported

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Improve arrows when related topic is not displayed

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Fix glitch when filtering domain graph per topic

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Fix identation

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Fix Gif size to adapt resolution

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Please uncrustify

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19973: Fix statistics backend StatusLevel references

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>

* Update loading graph gif (#213)

* Update loading graph gif

Signed-off-by: JesusPoderoso <[email protected]>

* Fix gif size

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>

* Add eProsima software icons to Fast DDS Monitor (#207)

* Add AMLIP icon and display in graph

Signed-off-by: JesusPoderoso <[email protected]>

* Add product icons

Signed-off-by: JesusPoderoso <[email protected]>

* Rename icons with backend names

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Update image names based on latest backend update

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Include app logos in png format

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Change .png logos to .svg logos

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Include logos in project resources

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Include logo in UI

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Update Panel behavior to allow section resize

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Update Domain Graph icon visibility to fix all alias width

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Fix logos and revert to .png format

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Apply rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Apply latest rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Apply latest rev suggestions

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19880: Please uncrustify

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>

* Include Fast DDS Monitor app ID while init monitor, and include new arguments in mocks  (#212)

* Refs #19865: Init monitor with proper app id

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19865: Fix errors in mocks

Signed-off-by: JesusPoderoso <[email protected]>

* Refs #19865: Please linters

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>

* Please linters

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants