-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20569] Migrate DLL API exporter to fastdds #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Signed-off-by: EduPonz <[email protected]>
EduPonz
force-pushed
the
feature/migrate_dll_api_and_linkage
branch
from
March 5, 2024 13:13
a3c9be5
to
e11a867
Compare
elianalf
approved these changes
Mar 5, 2024
…st DDS Signed-off-by: EduPonz <[email protected]>
elianalf
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
EduPonz
added a commit
that referenced
this pull request
Mar 25, 2024
* Refs #20569: Rename RTPS_DllAPI to FASTDDS_EXPORTED_API Signed-off-by: EduPonz <[email protected]> * Refs #20569: Fix compilation due to movement of LibrarySettings in Fast DDS Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]>
JLBuenoLopez
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Refs #20569: Rename RTPS_DllAPI to FASTDDS_EXPORTED_API Signed-off-by: EduPonz <[email protected]> * Refs #20569: Fix compilation due to movement of LibrarySettings in Fast DDS Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]>
EduPonz
added a commit
that referenced
this pull request
May 14, 2024
* Refs #20569: Rename RTPS_DllAPI to FASTDDS_EXPORTED_API Signed-off-by: EduPonz <[email protected]> * Refs #20569: Fix compilation due to movement of LibrarySettings in Fast DDS Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accounts for changes in: