[20734] Hotfix: type regeneration script #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
EduPonz
approved these changes
Apr 3, 2024
JesusPoderoso
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Refs #20734: fix type regeneration script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20734: regenerate types using script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
MiguelCompany
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Add type support regeneration utility (#108) * Refs #20677: Add type support regeneration utility Signed-off-by: EduPonz <[email protected]> * Refs #20677: Remove legacy script Signed-off-by: EduPonz <[email protected]> * Refs #20677: Apply suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> * Hotfix: type regeneration script (#115) * Refs #20734: fix type regeneration script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20734: regenerate types using script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #21226: Adjust script to python version 1.2.x Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: JesusPoderoso <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> Co-authored-by: José Luis Bueno López <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
* Add type support regeneration utility (#108) * Refs #20677: Add type support regeneration utility Signed-off-by: EduPonz <[email protected]> * Refs #20677: Remove legacy script Signed-off-by: EduPonz <[email protected]> * Refs #20677: Apply suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> * Hotfix: type regeneration script (#115) * Refs #20734: fix type regeneration script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20734: regenerate types using script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #21226: Adjust script to python version 1.2.x Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: JesusPoderoso <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> Co-authored-by: José Luis Bueno López <[email protected]> (cherry picked from commit 8057dd0)
JesusPoderoso
added a commit
that referenced
this pull request
Sep 2, 2024
* Add type support regeneration utility (#108) * Refs #20677: Add type support regeneration utility Signed-off-by: EduPonz <[email protected]> * Refs #20677: Remove legacy script Signed-off-by: EduPonz <[email protected]> * Refs #20677: Apply suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> * Hotfix: type regeneration script (#115) * Refs #20734: fix type regeneration script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20734: regenerate types using script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #21226: Adjust script to python version 1.2.x Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: JesusPoderoso <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]> Co-authored-by: José Luis Bueno López <[email protected]> (cherry picked from commit 8057dd0) Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#108 generalized the script to autogenerate the code related to the types contained in the repository. This script did not take into account that the python types contained in the same folder overwrite the generated CMakeLists.txt file if not passed together to Fast DDS-Gen in the same command. This PR fixes this issue.
Contributor Checklist
Reviewer Checklist