Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20765] Remove rtps reader implemantation made private #120

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 11, 2024

Description

This PR remove interfaces of headers

  • StatefulPersistentReader
  • StatefulReader
  • StatelessPersistentReader
  • StatelessReader

which were made private in this PR in Fast DDS:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Base automatically changed from 3.0.x-devel to main May 14, 2024 07:17
@MiguelCompany
Copy link
Member

@elianalf This needs a rebase

…ntReader, StatelessPersistentReader

Signed-off-by: elianalf <[email protected]>
@elianalf elianalf force-pushed the feature/make_rtps_reader_impl_private branch from d64fafa to 43e7630 Compare May 27, 2024 06:54
@MiguelCompany MiguelCompany added this to the v2.0.0 milestone May 27, 2024
@MiguelCompany MiguelCompany merged commit 5460ce6 into main Jun 7, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/make_rtps_reader_impl_private branch June 7, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants