Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21270] Support compilation againt Ubuntu 24.04 swig4.1 #153

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 28, 2024

Description

Due to an error, fastdds_python doesn't compile with current SWIG version (4.2.0) on Ubuntu 24.04. The fix is in swig 4.2.1 but it's not accessible in ubuntu noble. This ubuntu also contains the package swig4.1 but CMake is not prepare to find its executable. This PR fixes this using a trick.

Related to:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Support compilation againt Ubuntu 24.04 swig4.1 [21270] Support compilation againt Ubuntu 24.04 swig4.1 Jun 28, 2024
@JesusPoderoso JesusPoderoso added this to the v2.0.0 milestone Jul 4, 2024
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JesusPoderoso

This comment was marked as resolved.

richiware added 2 commits July 4, 2024 08:23
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 4, 2024
@richiware richiware merged commit 577f1ee into main Jul 4, 2024
4 checks passed
@richiware richiware deleted the bugfix/21268 branch July 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants