Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21137] Account for changes on RTPS writer refactor #157

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[21137] Account for changes on RTPS writer refactor #157

merged 1 commit into from
Jul 10, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jul 4, 2024 •
edited by EduPonz
Loading

Description

This PR adapts the code to the RTPS writer APIs refactor. In particular, the rename of members in WriterTimes.

Related implementation PR:

eProsima/Fast-DDS#5028

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • ❌ Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.0.0 milestone Jul 4, 2024
@MiguelCompany MiguelCompany mentioned this pull request Jul 4, 2024
Merged
10 tasks
@MiguelCompany MiguelCompany requested a review from EduPonz July 10, 2024 06:33
@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Jul 10, 2024
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 10, 2024
@EduPonz EduPonz merged commit ffae49c into main Jul 10, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/21082/writer branch July 10, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz