Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for string_255 type and fix discovery status memory leaks (backport #215) #218

Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 21, 2025

Description

This PR add support for using string_255 type in python applicatioons.

It also fixes the following warnings get when participant listener functions are called:

swig/python detected a memory leak of type 'eprosima::fastdds::rtps::ParticipantDiscoveryStatus *', no destructor found.
swig/python detected a memory leak of type 'eprosima::fastdds::rtps::WriterDiscoveryStatus *', no destructor found.
swig/python detected a memory leak of type 'eprosima::fastdds::rtps::ReaderDiscoveryStatus *', no destructor found.

@Mergifyio backport 2.1.x 2.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #215 done by [Mergify](https://mergify.com).

…ks (#215)

* Support using string_225 template instance in python

Signed-off-by: Raul Sanchez-Mateos <[email protected]>

* Fix DiscoveryStatus memory leak warnings

Signed-off-by: Raul Sanchez-Mateos <[email protected]>

---------

Signed-off-by: Raul Sanchez-Mateos <[email protected]>
(cherry picked from commit 23156aa)

# Conflicts:
#	fastdds_python/src/swig/fastcdr/cdr/fixed_size_string.i
@mergify mergify bot added the conflicts label Mar 21, 2025
Copy link
Author

mergify bot commented Mar 21, 2025

Cherry-pick of 23156aa has failed:

On branch mergify/bp/2.1.x/pr-215
Your branch is up to date with 'origin/2.1.x'.

You are currently cherry-picking commit 23156aa.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fastdds_python/src/swig/fastdds.i

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   fastdds_python/src/swig/fastcdr/cdr/fixed_size_string.i

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants