Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows ccache [19657] #65

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Fix windows ccache [19657] #65

merged 9 commits into from
Oct 23, 2023

Conversation

richiware
Copy link
Member

@richiware richiware commented Sep 29, 2023

Warning: Instead of generate VS solutions, with this PR Ninja solutions are generated.

Depends on:

@richiware richiware force-pushed the bugfix/windows-ccache branch 15 times, most recently from 58676de to 802f4c7 Compare October 2, 2023 09:15
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware force-pushed the bugfix/windows-ccache branch from 802f4c7 to 91f4f2a Compare October 2, 2023 09:17
Signed-off-by: Ricardo González Moreno <[email protected]>
@EduPonz EduPonz added this to the v1.3.1 milestone Oct 2, 2023
@richiware richiware force-pushed the bugfix/windows-ccache branch 2 times, most recently from a7bd0b6 to 6142780 Compare October 2, 2023 12:49
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware force-pushed the bugfix/windows-ccache branch from 6142780 to e630528 Compare October 2, 2023 13:08
@richiware richiware changed the title Fix windows ccache Fix windows ccache [19657] Oct 3, 2023
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions not really related with the changes in the PR.

@@ -54,7 +66,7 @@ jobs:
}
& $python_exec -m pip install -U pytest pywin32

- uses: actions/checkout@v2
- uses: actions/checkout@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be updated to use the action wrapped in eprosima-CI repository. Thus, updating the external action would be enough to upgrade every eProsima workflow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 2899e34

echo "$ccache_dir" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
Set-Item -Force -Path "env:PATH" -Value "$ccache_dir;$env:PATH"
ccache --version

- name: Setup ccache
uses: Chocobo1/setup-ccache-action@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to include this action into eProsima-CI external actions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 2899e34

@richiware richiware force-pushed the bugfix/windows-ccache branch 15 times, most recently from 3267b2f to 248fe41 Compare October 23, 2023 06:09
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware force-pushed the bugfix/windows-ccache branch from 248fe41 to 2899e34 Compare October 23, 2023 07:03
Signed-off-by: Ricardo González Moreno <[email protected]>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit 2308102 into main Oct 23, 2023
4 checks passed
@richiware richiware deleted the bugfix/windows-ccache branch October 23, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants