-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows ccache [19657] #65
Conversation
58676de
to
802f4c7
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
802f4c7
to
91f4f2a
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
a7bd0b6
to
6142780
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
6142780
to
e630528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions not really related with the changes in the PR.
.github/workflows/build_and_test.yml
Outdated
@@ -54,7 +66,7 @@ jobs: | |||
} | |||
& $python_exec -m pip install -U pytest pywin32 | |||
|
|||
- uses: actions/checkout@v2 | |||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be updated to use the action wrapped in eprosima-CI repository. Thus, updating the external action would be enough to upgrade every eProsima workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 2899e34
.github/workflows/build_and_test.yml
Outdated
echo "$ccache_dir" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append | ||
Set-Item -Force -Path "env:PATH" -Value "$ccache_dir;$env:PATH" | ||
ccache --version | ||
|
||
- name: Setup ccache | ||
uses: Chocobo1/setup-ccache-action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to include this action into eProsima-CI external actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 2899e34
3267b2f
to
248fe41
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
248fe41
to
2899e34
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Warning: Instead of generate VS solutions, with this PR Ninja solutions are generated.
Depends on: