Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20051] Fix redefinition of _wrap___eq__ #73

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Nov 28, 2023

eProsima/Fast-DDS#4045 introduced new == operators for ReturnCode_t, removing the existing template ones. This has caused a redefinition of _wrap___eq__ on the python bindings generated code. This PR fixes that issue by ignoring the new operators, thus keeping the same API in the bindings.

Fast DDS docs will not build until this PR is merged.

@EduPonz EduPonz changed the title [20051: Fix redefinition of _wrap___eq__ [20051] Fix redefinition of _wrap___eq__ Nov 28, 2023
@EduPonz EduPonz marked this pull request as ready for review November 28, 2023 07:16
@EduPonz EduPonz merged commit 94fa8a9 into main Nov 28, 2023
6 checks passed
@EduPonz EduPonz deleted the hotfix/operator_eq_redefinition branch November 28, 2023 10:01
EduPonz added a commit that referenced this pull request Dec 12, 2023
@EduPonz
Copy link
Author

EduPonz commented Dec 12, 2023

@Mergifyio backport 1.1.x 1.2.x 1.3.x

Copy link

mergify bot commented Dec 12, 2023

backport 1.1.x 1.2.x 1.3.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 12, 2023
Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
EduPonz added a commit that referenced this pull request Dec 13, 2023
Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
Signed-off-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Dec 13, 2023
Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
Signed-off-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Dec 13, 2023
Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
Signed-off-by: EduPonz <[email protected]>
EduPonz added a commit that referenced this pull request Dec 14, 2023
* Fix redefinition of _wrap___eq__ (#73)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
Signed-off-by: EduPonz <[email protected]>

* Refactor workflow

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
EduPonz added a commit that referenced this pull request Dec 14, 2023
* Fix redefinition of _wrap___eq__ (#73)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
Signed-off-by: EduPonz <[email protected]>

* Refactor workflow

Signed-off-by: EduPonz <[email protected]>

* Add /bigobj flag in windows

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
EduPonz added a commit that referenced this pull request Dec 14, 2023
* Fix redefinition of _wrap___eq__ (#73)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
Signed-off-by: EduPonz <[email protected]>

* Refactor workflow

Signed-off-by: EduPonz <[email protected]>

* Add /bigobj flag in windows

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
JesusPoderoso pushed a commit that referenced this pull request Feb 27, 2024
JesusPoderoso pushed a commit that referenced this pull request Feb 27, 2024
JesusPoderoso pushed a commit that referenced this pull request Feb 27, 2024
JesusPoderoso added a commit that referenced this pull request Feb 27, 2024
Signed-off-by: EduPonz <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
achintyamohan pushed a commit to boardwalkrobotics/Fast-DDS-python that referenced this pull request Aug 5, 2024
* Fix redefinition of _wrap___eq__ (eProsima#73)

Signed-off-by: EduPonz <[email protected]>
(cherry picked from commit 94fa8a9)
Signed-off-by: EduPonz <[email protected]>

* Refactor workflow

Signed-off-by: EduPonz <[email protected]>

* Add /bigobj flag in windows

Signed-off-by: EduPonz <[email protected]>

---------

Signed-off-by: EduPonz <[email protected]>
Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants