Skip to content

Commit

Permalink
Change default log filter configuration (#79)
Browse files Browse the repository at this point in the history
* Change default log filter configuration

Signed-off-by: Lucia Echevarria <[email protected]>

* Fix Release Notes

Signed-off-by: Lucia Echevarria <[email protected]>

---------

Signed-off-by: Lucia Echevarria <[email protected]>
  • Loading branch information
LuciaEchevarria99 authored Mar 25, 2024
1 parent f3952ce commit f6e0bcf
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/rst/notes/notes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This release includes the following **Configuration Features**:

This release includes the following **Documentation Updates**:

* Add a new :ref:`<spy_specs_logging>` section to the :ref:`<user_manual_configuration>` page.
* Add a new :ref:`Logging <spy_specs_logging>` section to the :ref:`Configuration <user_manual_configuration>` page.

This release includes the following **Dependencies Update**:

Expand Down
4 changes: 2 additions & 2 deletions docs/rst/user_manual/configuration.rst
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ Logging
Under the ``logging`` tag, users can configure the type of logs to display and filter the logs based on their content and category.
When configuring the verbosity to ``info``, all types of logs, including informational messages, warnings, and errors, will be displayed.
Conversely, setting it to ``warning`` will only show warnings and errors, while choosing ``error`` will exclusively display errors.
By default, the filter allows all errors to be displayed, while selectively permitting warning messages from ``DDSPIPE|FASTDDSSPY`` and informational messages from the ``FASTDDSSPY`` category.
By default, the filter allows all errors to be displayed, while selectively permitting warning messages from ``FASTDDSSPY`` and informational messages from the ``FASTDDSSPY`` category.

.. note::

Expand Down Expand Up @@ -327,7 +327,7 @@ By default, the filter allows all errors to be displayed, while selectively perm
or message of the logs.
- *string*
- info : ``FASTDDSSPY`` |br|
warning : ``DDSPIPE|FASTDDSSPY`` |br|
warning : ``FASTDDSSPY`` |br|
error : ``""``
- Regex string

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ ProcessReturnCode parse_arguments(

case optionIndex::ACTIVATE_DEBUG:
commandline_args.log_filter[utils::VerbosityKind::Error].set_value("");
commandline_args.log_filter[utils::VerbosityKind::Warning].set_value("(FASTDDSSPY|DDSPIPE)");
commandline_args.log_filter[utils::VerbosityKind::Warning].set_value("FASTDDSSPY");
commandline_args.log_filter[utils::VerbosityKind::Info].set_value("FASTDDSSPY");
commandline_args.log_verbosity = utils::VerbosityKind::Info;
break;
Expand Down
2 changes: 1 addition & 1 deletion fastddsspy_yaml/src/cpp/CommandlineArgsSpy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ namespace yaml {
CommandlineArgsSpy::CommandlineArgsSpy()
{
log_filter[utils::VerbosityKind::Info].set_value("FASTDDSSPY", utils::FuzzyLevelValues::fuzzy_level_default);
log_filter[utils::VerbosityKind::Warning].set_value("FASTDDSSPY|DDSPIPE",
log_filter[utils::VerbosityKind::Warning].set_value("FASTDDSSPY",
utils::FuzzyLevelValues::fuzzy_level_default);
log_filter[utils::VerbosityKind::Error].set_value("", utils::FuzzyLevelValues::fuzzy_level_default);
}
Expand Down

0 comments on commit f6e0bcf

Please sign in to comment.