Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty XTSAN tests list #76

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Empty XTSAN tests list #76

merged 1 commit into from
Jul 18, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

Up to eProsima/eProsima-CI#77 , almost every test using Fast-DDS was reporting multiple TSAN warnings that were in fact false positives. For this reason these tests were categorized as flaky when running the TSAN action, but after the update in eProsima-CI they should no longer fail.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.96%. Comparing base (dc4d1f5) to head (a1085cf).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   63.96%   63.96%           
=======================================
  Files          24       24           
  Lines        1149     1149           
  Branches      416      416           
=======================================
  Hits          735      735           
  Misses        148      148           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Juan Lopez Fernandez <[email protected]>
@rsanchez15 rsanchez15 merged commit 20c51f0 into main Jul 18, 2024
20 of 21 checks passed
@rsanchez15 rsanchez15 deleted the feature/remove-xtsan branch July 18, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants