Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new status attribute for entities [19307] #201

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

irenebm
Copy link
Member

@irenebm irenebm commented Aug 18, 2023

No description provided.

@irenebm irenebm temporarily deployed to codecov August 18, 2023 12:00 — with GitHub Actions Inactive
@irenebm irenebm changed the title Monitor Service implementation [19307] Add new status attribute for entities [19307] Sep 4, 2023
@irenebm irenebm marked this pull request as ready for review September 4, 2023 07:49
Signed-off-by: Irene Bandera <[email protected]>
@irenebm irenebm force-pushed the feature/monitor_service branch from 5819793 to 173be91 Compare September 4, 2023 07:52
@irenebm irenebm temporarily deployed to codecov September 4, 2023 07:52 — with GitHub Actions Inactive
Copy link
Contributor

@jepemi jepemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In src/cpp/subscriber/StatisticsParticipantListener.cpp in line 148, discovery_info.entity_status field has to be initialized.

Signed-off-by: Irene Bandera <[email protected]>
@irenebm irenebm temporarily deployed to codecov September 5, 2023 10:50 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov September 6, 2023 05:10 — with GitHub Actions Inactive
@rsanchez15 rsanchez15 merged commit 7d3f15f into main Sep 6, 2023
@rsanchez15 rsanchez15 deleted the feature/monitor_service branch September 6, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants