[21458] Add IDL format to topic entities #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carlosespicur
had a problem deploying
to
codecov
GitHub Actions
Failure
|
@Carlosespicur please rebase on top of master |
Carlosespicur
force-pushed
the
feature/topic-idls
branch
from
5ac1c37 to
11d3b4a
Compare
Carlosespicur
had a problem deploying
to
codecov
GitHub Actions
Failure
JesusPoderoso
force-pushed
the
feature/topic-idls
branch
from
11d3b4a to
1b3081b
Compare
JesusPoderoso
had a problem deploying
to
codecov
GitHub Actions
Failure
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
Signed-off-by: Carlosespicur <[email protected]>
Carlosespicur
force-pushed
the
feature/topic-idls
branch
from
1b3081b to
4fc830f
Compare
Carlosespicur
had a problem deploying
to
codecov
GitHub Actions
Failure
JesusPoderoso
suggested changes
Sep 10, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Carlosespicur <[email protected]>
Carlosespicur
had a problem deploying
to
codecov
GitHub Actions
Failure
Signed-off-by: Carlosespicur <[email protected]>
Carlosespicur
temporarily deployed
to
codecov
GitHub Actions
Inactive
Carlosespicur
temporarily deployed
to
codecov
GitHub Actions
Inactive
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Carlosespicur <[email protected]>
Carlosespicur
force-pushed
the
feature/topic-idls
branch
from
a314199 to
e791728
Compare
Carlosespicur
temporarily deployed
to
codecov
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to save the IDL representation of discovered types in a map, using the type name as key, to avoid unnecessary copies of the same data (in case of different entities publishing the same data type, for example).
Needed to be merged after:
Related PRS