[19743] Add expiration checks in database fragile pointers #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes
This PR fixes a crash reported in Fast DDS Monitor that can be reproduced by following the steps below:
In the database, associated locator entities are stored as fragile references (fragile_ptr) but returned as shared references (shared_ptr). When an associated locator entity (in this case a subscriber or endpoint) is deleted, its associated fragile_ptr becomes expired and is returned as nullptr when casted to shared_ptr, causing memory errors when trying to access an object member.
There are two ways to deal with this problem: