Refs #20492: Rename TCPTransportInterface::CloseOutputChannel to clea…

…nup_sender_resources Signed-off-by: EduPonz <[email protected]>
eProsima · Mar 6, 2024 · e4e2ca5 · e4e2ca5
1 parent 21d5a23
commit e4e2ca5
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/src/cpp/rtps/network/NetworkFactory.cpp b/src/cpp/rtps/network/NetworkFactory.cpp
@@ -484,7 +484,7 @@ void NetworkFactory::remove_participant_associated_send_resources(
         TCPTransportInterface* tcp_transport = dynamic_cast<TCPTransportInterface*>(transport.get());
         if (tcp_transport)
         {
-            tcp_transport->CloseOutputChannel(
+            tcp_transport->cleanup_sender_resources(
                 send_resource_list,
                 remote_participant_locators,
                 participant_initial_peers);

diff --git a/src/cpp/rtps/transport/TCPTransportInterface.cpp b/src/cpp/rtps/transport/TCPTransportInterface.cpp
@@ -1888,7 +1888,7 @@ void TCPTransportInterface::fill_local_physical_port(
     }
 }
 
-void TCPTransportInterface::CloseOutputChannel(
+void TCPTransportInterface::cleanup_sender_resources(
         SendResourceList& send_resource_list,
         const LocatorList& remote_participant_locators,
         const LocatorList& participant_initial_peers) const

diff --git a/src/cpp/rtps/transport/TCPTransportInterface.h b/src/cpp/rtps/transport/TCPTransportInterface.h
@@ -480,7 +480,7 @@ class TCPTransportInterface : public TransportInterface
      * @param remote_participant_locators Set of locators associated to the remote participant.
      * @param participant_initial_peers List of locators associated to the initial peers of the local participant.
      */
-    void CloseOutputChannel(
+    void cleanup_sender_resources(
             SendResourceList& send_resource_list,
             const LocatorList& remote_participant_locators,
             const LocatorList& participant_initial_peers) const;

diff --git a/test/unittest/transport/TCPv4Tests.cpp b/test/unittest/transport/TCPv4Tests.cpp
@@ -2116,7 +2116,7 @@ TEST_F(TCPv4Tests, remove_from_send_resource_list)
             IPLocator::setWan(wrong_output_locator, g_test_wan_address);
         }
         wrong_remote_participant_physical_locators.push_back(wrong_output_locator);
-        send_transport_under_test.CloseOutputChannel(
+        send_transport_under_test.cleanup_sender_resources(
             send_resource_list,
             wrong_remote_participant_physical_locators,
             initial_peer_list);
@@ -2125,7 +2125,7 @@ TEST_F(TCPv4Tests, remove_from_send_resource_list)
         // Using the correct locator should remove the channel resource
         LocatorList_t remote_participant_physical_locators;
         remote_participant_physical_locators.push_back(discovery_locator);
-        send_transport_under_test.CloseOutputChannel(
+        send_transport_under_test.cleanup_sender_resources(
             send_resource_list,
             remote_participant_physical_locators,
             initial_peer_list);
@@ -2140,7 +2140,7 @@ TEST_F(TCPv4Tests, remove_from_send_resource_list)
             IPLocator::setWan(initial_peer_locator, g_test_wan_address);
         }
         remote_participant_physical_locators.push_back(initial_peer_locator);
-        send_transport_under_test.CloseOutputChannel(
+        send_transport_under_test.cleanup_sender_resources(
             send_resource_list,
             remote_participant_physical_locators,
             initial_peer_list);

diff --git a/test/unittest/transport/TCPv6Tests.cpp b/test/unittest/transport/TCPv6Tests.cpp
@@ -527,7 +527,7 @@ TEST_F(TCPv6Tests, remove_from_send_resource_list)
     IPLocator::createLocator(LOCATOR_KIND_TCPv6, "::1", g_default_port + 2, wrong_output_locator);
     IPLocator::setLogicalPort(wrong_output_locator, 7410);
     wrong_remote_participant_physical_locators.push_back(wrong_output_locator);
-    send_transport_under_test.CloseOutputChannel(
+    send_transport_under_test.cleanup_sender_resources(
         send_resource_list,
         wrong_remote_participant_physical_locators,
         initial_peer_list);
@@ -536,7 +536,7 @@ TEST_F(TCPv6Tests, remove_from_send_resource_list)
     // Using the correct locator should remove the channel resource
     LocatorList_t remote_participant_physical_locators;
     remote_participant_physical_locators.push_back(output_locator_1);
-    send_transport_under_test.CloseOutputChannel(
+    send_transport_under_test.cleanup_sender_resources(
         send_resource_list,
         remote_participant_physical_locators,
         initial_peer_list);
@@ -545,7 +545,7 @@ TEST_F(TCPv6Tests, remove_from_send_resource_list)
     // Using the initial peer locator should not remove the channel resource
     remote_participant_physical_locators.clear();
     remote_participant_physical_locators.push_back(output_locator_2);
-    send_transport_under_test.CloseOutputChannel(
+    send_transport_under_test.cleanup_sender_resources(
         send_resource_list,
         remote_participant_physical_locators,
         initial_peer_list);