Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build broken in Windows due to not finding ASIO #1173

Closed
rotu opened this issue Apr 22, 2020 · 5 comments
Closed

Build broken in Windows due to not finding ASIO #1173

rotu opened this issue Apr 22, 2020 · 5 comments

Comments

@rotu
Copy link
Contributor

rotu commented Apr 22, 2020

Expected Behavior

Build should succeed

Current Behavior

https://github.com/ros2/rmw_cyclonedds/runs/610261628?check_suite_focus=true
Build fails with missing ASIO:

Starting >>> fastrtps
--- output: connext_cmake_module
[3.485s] -- The C compiler identification is MSVC 19.25.28614.0
[4.344s] -- The CXX compiler identification is MSVC 19.25.28614.0
[4.438s] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.25.28610/bin/Hostx64/x64/cl.exe
[5.266s] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.25.28610/bin/Hostx64/x64/cl.exe - works
[5.266s] -- Detecting C compiler ABI info
[6.094s] -- Detecting C compiler ABI info - done
[6.094s] -- Detecting C compile features
[6.094s] -- Detecting C compile features - done
[6.094s] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.25.28610/bin/Hostx64/x64/cl.exe
[6.860s] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.25.28610/bin/Hostx64/x64/cl.exe - works
[6.860s] -- Detecting CXX compiler ABI info
[7.703s] -- Detecting CXX compiler ABI info - done
[7.719s] -- Detecting CXX compile features
[7.719s] -- Detecting CXX compile features - done
[7.719s] -- Found ament_cmake: 0.8.1 (D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/ament_cmake/share/ament_cmake/cmake)
[8.047s] -- Found PythonInterp: C:/python37/python.exe (found suitable version "3.7.6", minimum required is "3") 
[8.047s] -- Using PYTHON_EXECUTABLE: C:/python37/python.exe
[8.438s] -- Override CMake install command with custom implementation using symlinks instead of copying resources
[8.969s] -- Found ament_lint_auto: 0.9.1 (D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/ament_lint_auto/share/ament_lint_auto/cmake)
[9.235s] -- Added test 'copyright' to check for copyright in CMake / C / C++ / Python code
[9.281s] -- Added test 'cppcheck' to perform static code analysis on C / C++ code
[9.281s] -- Configured cppcheck include dirs: 
[9.344s] -- Added test 'cpplint' to check C / C++ code against the Google style
[9.406s] -- Added test 'lint_cmake' to check CMake code style
[9.531s] -- Added test 'uncrustify' to check C / C++ code style
[9.531s] -- Added test 'xmllint' to check XML markup files
[9.625s] -- Configuring done
[9.735s] -- Generating done
[9.735s] -- Build files have been written to: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/build/connext_cmake_module
[9.860s] Microsoft (R) Build Engine version 16.5.0+d4cbfca49 for .NET Framework
[9.860s] Copyright (C) Microsoft Corporation. All rights reserved.
[9.860s] 
[10.250s]   Checking Build System
[10.375s]   Building Custom Rule D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/src/ros2/rosidl_typesupport_connext/connext_cmake_module/CMakeLists.txt
[10.469s] -- Execute custom install script
[10.469s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/ament_index/resource_index/package_run_dependencies/connext_cmake_module
[10.485s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/ament_index/resource_index/parent_prefix_path/connext_cmake_module
[10.516s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/environment/ament_prefix_path.bat
[10.531s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/environment/ament_prefix_path.dsv
[10.547s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/environment/path.bat
[10.563s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/environment/path.dsv
[10.578s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/local_setup.bat
[10.594s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/local_setup.dsv
[10.625s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/package.dsv
[10.656s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/ament_index/resource_index/packages/connext_cmake_module
[10.672s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/cmake/connext_cmake_module-extras.cmake
[10.719s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/cmake/connext_cmake_moduleConfig.cmake
[10.735s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/cmake/connext_cmake_moduleConfig-version.cmake
[10.766s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/package.xml
[10.781s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/cmake/Modules/FindConnext.cmake
[10.797s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/cmake/check_abi.cmake
[10.813s] -- Symlinking: D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/install/connext_cmake_module/share/connext_cmake_module/cmake/check_abi.cpp
---
Finished <<< connext_cmake_module [10.9s]
Starting >>> fastrtps_cmake_module
--- output: fastrtps
[0.188s] -- Setting build type to 'Release' as none was specified.
[1.438s] -- The C compiler identification is MSVC 19.25.28614.0
[2.266s] -- The CXX compiler identification is MSVC 19.25.28614.0
[2.313s] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.25.28610/bin/Hostx64/x64/cl.exe
[3.188s] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.25.28610/bin/Hostx64/x64/cl.exe - works
[3.188s] -- Detecting C compiler ABI info
[3.954s] -- Detecting C compiler ABI info - done
[3.954s] -- Detecting C compile features
[3.954s] -- Detecting C compile features - done
[3.954s] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.25.28610/bin/Hostx64/x64/cl.exe
[4.719s] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.25.28610/bin/Hostx64/x64/cl.exe - works
[4.719s] -- Detecting CXX compiler ABI info
[5.454s] -- Detecting CXX compiler ABI info - done
[5.454s] -- Detecting CXX compile features
[5.454s] -- Detecting CXX compile features - done
[5.454s] -- Configuring Fast RTPS
[5.454s] -- Version: 1.10.0
[5.454s] -- To change the version modify the file configure.ac
[5.454s] -- Check if the system is big endian
[5.454s] -- Searching 16 bit integer
[5.454s] -- Looking for sys/types.h
[6.282s] -- Looking for sys/types.h - found
[6.282s] -- Looking for stdint.h
[7.141s] -- Looking for stdint.h - found
[7.141s] -- Looking for stddef.h
[7.969s] -- Looking for stddef.h - found
[7.969s] -- Check size of unsigned short
[8.782s] -- Check size of unsigned short - done
[8.782s] -- Searching 16 bit integer - Using unsigned short
[9.579s] -- Check if the system is big endian - little endian
[9.594s] -- fastcdr library found...
[9.985s] CMake Error at C:/Program Files/CMake/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
[9.985s]   Could NOT find Asio (missing: ASIO_INCLUDE_DIR)
[9.985s] Call Stack (most recent call first):
[9.985s]   C:/Program Files/CMake/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:445 (_FPHSA_FAILURE_MESSAGE)
[9.985s]   cmake/modules/FindAsio.cmake:16 (find_package_handle_standard_args)
[9.985s]   cmake/common/eprosima_libraries.cmake:96 (find_package)
[9.985s]   CMakeLists.txt:220 (eprosima_find_thirdparty)
[9.985s] 
[9.985s] 
[9.985s] -- Configuring incomplete, errors occurred!
[9.985s] See also "D:/a/rmw_cyclonedds/rmw_cyclonedds/ros_ws/build/fastrtps/CMakeFiles/CMakeOutput.log".
---
--- stderr: fastrtps
CMake Error at C:/Program Files/CMake/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
  Could NOT find Asio (missing: ASIO_INCLUDE_DIR)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:445 (_FPHSA_FAILURE_MESSAGE)
  cmake/modules/FindAsio.cmake:16 (find_package_handle_standard_args)
  cmake/common/eprosima_libraries.cmake:96 (find_package)
  CMakeLists.txt:220 (eprosima_find_thirdparty)


---
Failed   <<< fastrtps	[ Exited with code 1 ]
@rotu rotu mentioned this issue Apr 22, 2020
Merged
@sloretz
Copy link
Contributor

sloretz commented Apr 22, 2020

just noting it looks like asio was sucesfully installed from a chocolatey package , which has been the recommended practice for a while.

@MiguelCompany
Copy link
Member

@rotu We couldn't reproduce this.

Windows ROS2 nightlies are building successfully: https://ci.ros2.org/view/nightly/job/nightly_win_rel/1528/consoleFull#console-section-144

@rotu
Copy link
Contributor Author

rotu commented Apr 23, 2020

Trying with the --symlink-install flag, which I suspect as a contributing factor:

  • Windows Build Status

@rotu rotu mentioned this issue Apr 23, 2020
Closed
@rotu
Copy link
Contributor Author

rotu commented Apr 23, 2020

That wasn't it. I'm seeing on the newer Windows CI builds that we're building Fast-RTPS, whereas we weren't before. I'm not sure how that crept in. The CI is supposed to strip everything that isn't a dependency.

@rotu
Copy link
Contributor Author

rotu commented Apr 24, 2020

@MiguelCompany Here's how the dependency crept in ros2/rmw_dds_common#16
It's not an issue that should be affecting Cyclone, so feel free to investigate further or close as a "wontfix". It may be caused by rosdep install with --rosdistro eloquent, which is certainly a mistake.

rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 25, 2020
@rotu
Exclude other RMW from Github CI build
051deeb 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
@rotu rotu mentioned this issue Apr 25, 2020
Merged
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 25, 2020
@rotu
Exclude other RMW from Github CI build
6c93ba3 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 28, 2020
@rotu
Exclude other RMW from Github CI build
705302c 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 28, 2020
@rotu
Exclude other RMW from Github CI build
cd7e2f3 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
rotu added a commit to RoverRobotics-forks/rmw_cyclonedds that referenced this issue Apr 28, 2020
@rotu
Exclude other RMW from Github CI build
3dc89b8 
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
rotu added a commit to ros2/rmw_cyclonedds that referenced this issue Apr 29, 2020
@rotu
Exclude other RMW from Github CI build (#168)
3397c95 
Since #145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes #164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rotu @sloretz @MiguelCompany