[20301] Make XML Parser API private #4318

JLBuenoLopez · 2024-01-29T15:06:52Z

Description

This PR makes XML parser API private. Some API used by examples and blackbox tests is exposed in DomainParticipantFactory and RTPSDomain:

Expose library settings and update structure to fastdds namespace in DomainParticipantFactory and RTPSDomain.
Expose get dynamic type by name in DomainParticipantFactory.

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
[NO] Changes are ABI compatible.
[NO] Changes are API compatible.
New feature has been added to the versions.md file (if applicable).
[PENDING] New feature has been documented/Current behavior is correctly described in the documentation.
[N/A] Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

elianalf

This PR makes XML Parser APIs private and also defines

new LibrarySettings class (replace LibrarySettingsAttributes) and associated unittest (library_settings_test and DomainParticipantFactoryLibrarySettings)
new function get_dynamic_type_builder_from_xml_by_name() and associated test (DomainParticipantFactoryGetDynamicTypeBuilder).
All the tests passed locally without errors: only one warning.

include/fastdds/dds/domain/DomainParticipantFactory.hpp

test/unittest/rtps/domain/RTPSDomainTests.cpp

JLBuenoLopez · 2024-02-29T11:27:42Z

@richiprosima please test_3 this

JLBuenoLopez · 2024-03-01T06:17:40Z

@richiprosima please test_3 this

JLBuenoLopez · 2024-03-05T06:55:36Z

@richiprosima please test_3 this

JLBuenoLopez · 2024-03-05T06:57:59Z

@richiprosima please test_3 this

Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]>

Signed-off-by: EduPonz <[email protected]>

* Refs #20301: move XML Parser implementation to root source folder Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: sort alphabetically source files Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: make XML Parser private Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: remove private headers from Blackbox tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: new LibrarySettings class superseding LibrarySettingsAttributes Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: add library settings DDS & RTPS API. RTPSDomainTests testing the new API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: library settings DDS API test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: generate monitor service types in blackbox types and use them in corresponding test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: XML profile manager get dynamic type builder wrapper and related test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: refactor XML library settings, use new migrated structure Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: migrate to public API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: reintroduce private headers in blackbox tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: update versions.md and copyright Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: remove exportation macro from private API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: remove participant without using mocked code Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: avoid using protected interface name Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: avoid using non-exported API in ParticipantTests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fix Publisher and Subscriber tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: add get_topic_attributes_from_profile API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: get topic attributes from profile test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fixes after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fix memory leak Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: Run Github Windows CI on 3.0.x-devel PRs Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> Co-authored-by: EduPonz <[email protected]>

* GitHub CI for 3.0.x (#4358) * Refs #19452: Change github workflow for discovery-server Signed-off-by: elianalf <[email protected]> * Refs #19452: Change github workflow for documentation Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> * Branch-out v3.0.0 (#4251) * Refs #19452: branch-out v3.0.0 Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update XML schema name Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove doc legacy folder. Move github banner to resources folder Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove .settings folder Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove legacy m4 folder Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove legace files from utils folder Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: rename to FASTDDS_DEFAULT_PROFILES_FILE and FASTDDS_DEFAULT_PROFILES Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update XML Schema name Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update to Fast DDS, remove references to FastRTPS, remove legacy files Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update Doxygen modules Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: examples, use fastdds headers instead of fastrtps ones Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: rename security logging macros Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: use fastdds headers Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update to fastdds headers in public headers Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update to Fast DDS configuration files. Rename deprecation macro Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: use fastdds headers. Update header guards Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update fastrtps.rc Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove System deprecated class Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove DataWriter deprecated methods Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove deprecated methods in ServerAttributes Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove deprecated method in LocatorList Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove deprecated attributes in TCPTransportDescriptor Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove SampleInfo deprecated constexpr Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove deprecated participant discovery callback Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove TypeObject deprecated API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove RPC headers deprecated API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: rename project to Fast DDS. Update examples, tools and fuzzer CMakeLists. Changes required to build library after updating to fastdds headers Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: fix examples build Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: fixes in test suite Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove deprecated API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update versions.md Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove PSM source files and tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: move TopicAttributes implementation to src/cpp/rtps/attributes folder Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: sort alphabetically source files Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove Fast RTPS legacy API implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: remove PSM API headers and implementation. Fixes to ensure tests build correctly Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: update to libfastdds.version name and remove exported dds namespace Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: fixes after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: apply review suggestion related to XML header Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: missing XML xmlns Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: fixes in TCPv6 unit tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: keep legacy installation folder until migration is completed Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19452: fixes in TCPv4 unit tests Signed-off-by: elianalf <[email protected]> * Refs #19452: Remove Readme.html.in installation since it has been removed Signed-off-by: elianalf <[email protected]> * Refs #19452: Remove fastrtps_example.cpp references Signed-off-by: elianalf <[email protected]> * Refs #19452: Add head branch for discovery-server in github ci action Signed-off-by: elianalf <[email protected]> * Refs 19452: Update default branch for asan Signed-off-by: elianalf <[email protected]> * Refs #19452: Change Mac Github CI to work for 3.0.x-devel Signed-off-by: elianalf <[email protected]> * Refs 19452: Add namespace where missing Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: elianalf <[email protected]> Co-authored-by: elianalf <[email protected]> Fixes after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Remove deprecated fastrtps tests (#4270) * Refs #20340: Remove deprecated fastrtps tests Signed-off-by: elianalf <[email protected]> Refs #20340: Restore XML parser tests Signed-off-by: elianalf <[email protected]> * Refs #20340: Update version.md file Signed-off-by: elianalf <[email protected]> * Refs 20340: Remove no longer supported FASTRTPS_API_TESTS Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> * Remove fixed_size_string file in fastrtps (#4269) * Refs #20392: Remove fastrtps fixed_size_string lib Signed-off-by: elianalf <[email protected]> * Refs #20392: Update tests dependencies Signed-off-by: elianalf <[email protected]> * Refs #20392: Update namespace fastcdr Signed-off-by: elianalf <[email protected]> * Refs #20392: Reorder libraries to follow google style order Signed-off-by: elianalf <[email protected]> * Refs #20392: Remove include of unused fixed_size_string Signed-off-by: elianalf <[email protected]> * Refs #20392: Remove deprecated tests of fixed_size_string Signed-off-by: elianalf <[email protected]> * Refs #20392: Uncrustify Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> * Make XML Parser API private (#4318) * Refs #20301: move XML Parser implementation to root source folder Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: sort alphabetically source files Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: make XML Parser private Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: remove private headers from Blackbox tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: new LibrarySettings class superseding LibrarySettingsAttributes Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: add library settings DDS & RTPS API. RTPSDomainTests testing the new API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: library settings DDS API test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: generate monitor service types in blackbox types and use them in corresponding test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: XML profile manager get dynamic type builder wrapper and related test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: refactor XML library settings, use new migrated structure Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: migrate to public API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: reintroduce private headers in blackbox tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: update versions.md and copyright Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: remove exportation macro from private API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: remove participant without using mocked code Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: avoid using protected interface name Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: avoid using non-exported API in ParticipantTests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fix Publisher and Subscriber tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: add get_topic_attributes_from_profile API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: get topic attributes from profile test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fixes after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: fix memory leak Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20301: Run Github Windows CI on 3.0.x-devel PRs Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]> Co-authored-by: EduPonz <[email protected]> * Migrate DLL API exporter and auto linkage to fastdds (#4500) * Refs #20569: Rename RTPS_DllAPI to FASTDDS_EXPORTED_API Signed-off-by: EduPonz <[email protected]> * Refs #20569: Move fastrtps/fastrtps_dll.h to fastdds/fastdds_dll.hpp Signed-off-by: EduPonz <[email protected]> * Refs #20569: Move fastrtps/eProsima_auto_link.h to fastdds/fastdds_auto_link.hpp Signed-off-by: EduPonz <[email protected]> * Refs #20569: Uncrustify Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> * Change windows file names (#4576) * Refs #20390: Change fastdds-config.cmake name Signed-off-by: elianalf <[email protected]> * Refs #20390: Change fastdds.manifest.in name Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> * Migrate classes from include/fastrtps to fastdds (#4518) * Refs #20566: Migrate fastrtps/attributes/TopicAttributes.h to fastdds/rtps/attributes Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Migrate fastrtps/utils/IPFinder.h to fastdds/utils Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Migrate fastrtps/utils/IPLocator.h to fastdds/utils Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Migrate fastrtps/utils/collections to fastdds/utils/collections Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Migrate fastrtps/utils/fixed_size_bitmap.hpp to fastdds/utils/ Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Migrate fastrtps/utils/md5.h to fastdds/utils Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Migrate fastrtps/utils/TimedConditionVariable.hpp to fastdds/utils Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Migrate fastrtps/utils/TimedMutex.hpp to fastdds/utils Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Uncrustify Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Refs #20566: Reorder header following google style Signed-off-by: elianalf <[email protected]> * Regenerate file with updated headers Signed-off-by: elianalf <[email protected]> * Refs #20566: fix rebase error Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: elianalf <[email protected]> Signed-off-by: EduPonz <[email protected]> * Update versions in fastdds.repos file (#4621) Signed-off-by: elianalf <[email protected]> * Make private the necessary headers from include/fastrtps (#4545) * Refs #20567: Include what you use in latency test Signed-off-by: EduPonz <[email protected]> * Refs #20567: Remove unnecesary and deprecated headers Signed-off-by: EduPonz <[email protected]> * Refs #20567: Migrate allocations test to DDS Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make ParticipantAttributes private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make ReplierAttributes & RequesterAttributes private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make PublisherAttributes private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make SubscriberAttributes private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make Discovery private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make ProxyPool private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make Semaphore private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make MessageReceiver private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make BuiltinProtocols private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make Liveliness private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make LivelinessManager private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make LivelinessData private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make shared_mutex private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make StringMatching private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make TimeConversion private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Make DBQueue private Signed-off-by: EduPonz <[email protected]> * Refs #20567: Add notes to versions.md Signed-off-by: EduPonz <[email protected]> * Refs #20567: Apply Eliana's suggestions Signed-off-by: EduPonz <[email protected]> * Refs #20567: Correctly export API in Windows for ReplierQos and RequesterQos Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: EduPonz <[email protected]> * Create Participant with default profile (use environment XML configuration) (#4534) * Refs #20543: Default Domain Id value Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Rename method Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Apply rev suggestions Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Address missed suggestions Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Apply last(?) revision suggestion Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Apply Edu' suggestion Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Apply Edu' suggestion (2) Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Add missing test Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Fix test Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Apply rev suggestions Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Instanciate test listener in stack Signed-off-by: JesusPoderoso <[email protected]> * Refs #20543: Include new feature in versions.md Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> * Refactor Statistics module IDL (#4638) * Refs #20714: refactor statistics module IDL Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20714: regenerate types Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20714: correctly use new statistics IDL Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Partial implementation of X-Types1.3 (#4640) * Partial implementation of X-Types1.3 DDS ReturnCode_t generated from IDL file (#4041) * Refs #19975. Implementation on library Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19975. Fix all compilation errors Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19975. Fix forgotten compilation errors Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19975. Fix old use of operator ! Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Regenerated IDL files with types header-only fastddsgen version (#4042) * Refs #19971. Remove -cdr option in script Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19960. Apply types header-only Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19960. Fix compilation errors after rebase Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #19960. Trying compile VS2017 Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Fixed error when compiling with FASTDDS_STATISTICS=OFF (#4059) Signed-off-by: adriancampo <[email protected]> New dynamic_language_binding.idl (#4058) Signed-off-by: Ricardo González Moreno <[email protected]> TypeObjectUtils class (#3974) * Refs #19648: XTypes v1.3 Annex B TypeObject IDL Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: generate TypeObject.idl code with Fast DDS-Gen v3.0.1 Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: regenerate using bugfixes/warnings-regressions branch Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: build new TypeObject generated code. Update headers Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: WIP, due to external annotation max serialized size is not correctly calculated Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: include BuiltinAnnotations.idl Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: builtin annotations already defined within Fast DDS-Gen: escape annotation name to redefine and generate TypeObject. Remove builtin annotations dependent on any block not yet supported Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: typo Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: update script to generate Builtin annotations TypeObject Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: API proposal Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: use xtypes1_3 namespace to avoid TypeInformation conflict Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply design suggestions Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: add exceptions based on DDS PSM CXX specification Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: API for bitmask flags, strings, sequences and arrays TypeIdentifiers. Consistency unit tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: plain maps TypeIdentifier API and unit tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: plain collections consistency methods and refactor corresponding tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: register TypeObjectRegistry in DomainParticipantFactory and create accesor to the API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: register indirect hash TypeIdentifiers API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: refactor to prevent pointer use Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: add register indirect hash TypeIdentifiers tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: AnnotationParameterValue API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: add TypeObjectUtils API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: more API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: regenerate using external implementation. Refactor code to build Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: include API to TypeObjectRegistry Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: finish public API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: generate BuiltinAnnotations types to check builtin annotations consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: add API to access the builtin annotation complete TypeIdentifier Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: namespace. Include builtin annotations names and kinds and avoid conflict with extensibility kinds Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: add consistency API: builtin annotations, complete struct members Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: union type consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: annotation cross consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: modify API for TypeLookupService Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix calls to TypeObjectRegistry Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: builtin annotations not included in custom annotations sequence Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: CompleteAliasBody consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: CompleteEnumeratedLiteral consistency and fixes Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: enum literal sequence consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: CompleteBitflag consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: bitflag sequence consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: CompleteBitfield consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: bitfield sequence consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix bug Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: update versions.md Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: regenerate types using script (only IDLs introduced in this PR has been updated) Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix wartnings Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: remove non-applicable TODO Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix build issue Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix Clang warnings Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestion: keyed members cannot be optional Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestion: fix MemberFlags consistency checks Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestion: leverage insert API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestions: improve error messages Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestion: check invalid union member name Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestion: improve readability Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestions: imporvements to tests and map key consistency alias check Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestion: ensure correct element order in sequences Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: apply review suggestion. Bitfield name might be empty. Method to check direct hash type identifiers consistency (pending implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: use Fast DDS-Gen names Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: use IDL from specification (https://www.omg.org/spec/DDS-XTypes/20190301/dds-xtypes_typeobject.idl). Update script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: migrate to DDS ReturnCode_t Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix IDL typo Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: generate types Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: rename TypeIdentifierParameter to avoid conflict Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: rename xtypes namespace Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix missing information from IDL Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: remove warnings Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19595: fix tests compilation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: regenerate BuiltinAnnotation types without empty namespaces Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix uninitialized warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix test linkage Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: WIP Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix primitive type long double Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19648: fix windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Moved all typelookupservice files to src (#4053) * Moved all typelookupservice files to src Signed-off-by: adriancampo <[email protected]> * Renamed typelookupservice directory. Fix include order. Signed-off-by: adriancampo <[email protected]> * Fix include order. Uncrustify. Signed-off-by: adriancampo <[email protected]> * Refs #20043: Reordered includes. Fixed mock path. Signed-off-by: adriancampo <[email protected]> --------- Signed-off-by: adriancampo <[email protected]> New TypeDescriptor (#4074) * Refs 17138. New TypeDescriptor Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Update doxygen. Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Remove forward class not used Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Apply suggestions Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> TypeObjectRegistry implementation (#3996) * Refs #19837: add TypeObjectRegistry::register_type_identifier test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::register_type_identifier implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: test fixes Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: add TypeObjectUtils::complete_type_object_consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::register_type_object implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::register_type_object test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_type_object skeleton Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_alias_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: use const references in ranged for loops Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_annotation_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_struct_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_union_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_bitset_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_sequence_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_array_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_map_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_enumerated_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::build_minimal_from_complete_bitmask_type implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::get_type_identifier Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: fix tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObject::get_type_identifiers implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: add TypeObject::get_type_identifiers test Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: add TypeObject::get_type_objects tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::get_type_objects implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry constructor implementation. Register primitive TypeIdentifiers Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::register_type_object implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::get_type_object implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: add precondition to public API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::get_type_information implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::is_builtin_annotation implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::is_type_identifier_known implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectRegistry::get_type_dependencies impl Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: apply review suggestion, protect against concurrent access to collections Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: apply review suggestion, rename to calculate_type_identifier Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: define NO_DEPENDENCIES constant Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: apply review suggestions to TypeObjectRegistry implementation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: apply review suggestions, imporve TypeObjectRegistry tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: TypeObjectUtils::direct_hash_type_identifier_consistency impl Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: remove Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: regenerate code to avoid Clang warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19837: use ExtensibilityKind and TryConstructKind defined in DynamicType IDL Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> New MemberDescriptor API (#4096) * Refs 17138. New MemberDescriptor API Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Apply suggestions Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Regenerate code with fastddsgen and fix idl files (#4080) * Refs #20070. Regenerate source code and fix idl errors Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20070. Fix missing include Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #20070. Trying compile VS2017 Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> New AnnotationDescriptor API (#4121) * Refs 17138. New AnnotationDescriptor API Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Apply suggestion Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Added idl file and generated types for typelookup service. (#4054) * Added idl file and generated types for typelookup service. Signed-off-by: adriancampo <[email protected]> * Fix directory name. Signed-off-by: adriancampo <[email protected]> * Updated IDL. Removed old generated files. Signed-off-by: adriancampo <[email protected]> * Refs #19794: Updated generated types Signed-off-by: adriancampo <[email protected]> * Refs #19794: Changes to type generation script Signed-off-by: adriancampo <[email protected]> * Refs #19794: Changes to make TypeLookup compile. Fix to type generation script. Signed-off-by: adriancampo <[email protected]> * Refs #19794: Uncrustify Signed-off-by: adriancampo <[email protected]> * Refs #19794: Updated fastddsgen generated file Signed-off-by: adriancampo <[email protected]> * Refs #19794: Applied suggestions Signed-off-by: adriancampo <[email protected]> * Refs #19794: Applied suggestions to update_generated_code_from_idl script Signed-off-by: adriancampo <[email protected]> * Refs #19794: fixed error in script Signed-off-by: adriancampo <[email protected]> * Refs #19794: Added OMG idl for rpc types Signed-off-by: adriancampo <[email protected]> * Refs #19794: Uncrustified Signed-off-by: adriancampo <[email protected]> * Refs #19794: Added new rpc_typesPubSubTypes.cxx to CMakeLists Signed-off-by: adriancampo <[email protected]> * Refs #19794: Updated script idl and generated types after fastddsgen changes. Signed-off-by: adriancampo <[email protected]> * Refs #19794: Updated generated code. Signed-off-by: adriancampo <[email protected]> * Refs #19794: Applied suggestions Signed-off-by: adriancampo <[email protected]> --------- Signed-off-by: adriancampo <[email protected]> Created TypeObjectRegistryObserver (#4092) * Refs #20062: Created TypeObjectRegistryObserver class. Signed-off-by: adriancampo <[email protected]> * Refs #20062: Chamges to TypeObjectUtils to work with TypeObjectRegistryObserver. Updated some generated types. Signed-off-by: adriancampo <[email protected]> * Refs #20062: Removed TypeObjectFactory uses from discovery Signed-off-by: adriancampo <[email protected]> * Refs #20062: Uses of TypeObjectRegistryObserver in discovery Signed-off-by: adriancampo <[email protected]> * Refs #20062: Changed TypeObjectRegistryObserver friend class for a virtual interface (tests not compiling). Signed-off-by: adriancampo <[email protected]> * Refs #20062: Fixed tests compilation Signed-off-by: adriancampo <[email protected]> * Refs #20062: Applied suggestions Signed-off-by: adriancampo <[email protected]> * Undid uncrustify changes to TypeObjectUtils.cpp --------- Signed-off-by: adriancampo <[email protected]> New DynamicTypeMember API (#4138) * Refs 17138. New DynamicTypeMember API Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Apply suggestions Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Apply suggestion Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> New DynamicType API (#4141) * Refs 17138. New DynamicType API Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Apply suggestions Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Create async_get_type method and remove typelookup settings (#4126) * Refs #20116: Removed TypeLookupSettings. Cleaned TypeLookupManager. Signed-off-by: adriancampo <[email protected]> * Refs #20116: Removed auto_fill_type_object Signed-off-by: adriancampo <[email protected]> * Refs #20116: Applied suggestions Signed-off-by: adriancampo <[email protected]> * Refs #20116: Crated instance of TypeLookupManager in BuiltinProtocols. Improved documentation of TypeLookupManager Signed-off-by: adriancampo <[email protected]> * Refs #20116: Applied suggestions Signed-off-by: adriancampo <[email protected]> * Refs #20116: Added TODO for ReturnCodes of async_get_type Signed-off-by: adriancampo <[email protected]> * Refs #20116: Fixed DomainParticipantImpl mock Signed-off-by: adriancampo <[email protected]> * Refs #20116: Removed access to private api from mock. Signed-off-by: adriancampo <[email protected]> * Refs #20116: Removed get_types and get_type_dependencies methods from DomainParticipant. Signed-off-by: adriancampo <[email protected]> * Refs #20116: Removed the old methods related with TypeLookup service. Signed-off-by: adriancampo <[email protected]> * Refs #20116: Removed tests from from ParticipantTests. Signed-off-by: adriancampo <[email protected]> * Refs #20116: Removed unnused member. Signed-off-by: adriancampo <[email protected]> --------- Signed-off-by: adriancampo <[email protected]> New DynamicTypeBuilder API (#4157) * Refs 17138. New DynamicTypeBuilder API Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Apply suggestions Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> New DynamicTypeBuilderFactory API (#4170) * Refs 17138. New DynamicTypeBuilderFactory API Signed-off-by: Ricardo González Moreno <[email protected]> * Refs 17138. Apply suggestions. Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Move dds types (#4179) Signed-off-by: Ricardo González Moreno <[email protected]> Update TypeInformationParameter to contain xtype (#4140) * Refs #20131: Updated TypeInformationParameter TypeInformation to xtypes Signed-off-by: adriancampo <[email protected]> * Refs #20131: Removed old TypeObject header from QosPolicies Signed-off-by: adriancampo <[email protected]> * Refs #20131: Removed old type validation. Signed-off-by: adriancampo <[email protected]> * Refs #20131: Fixed windows warning. Signed-off-by: adriancampo <[email protected]> * Refs #20131: Removed tests for private api. Signed-off-by: adriancampo <[email protected]> * Refs #20131: Included Types.hpp for DomainId_t Signed-off-by: adriancampo <[email protected]> --------- Signed-off-by: adriancampo <[email protected]> Bugfix: fix feature/xtypes1.3 branch build (#4228) * Refs #20129: fixes to build feature/xtypes1.3 branch Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix compilation with security Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: apply review suggestion Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types after fixing union bug Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix for building without Statistics module Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Implement TypeLookupManager async_get_type (#4177) * Refs #20130: Use TypeLookupManager in EDP Signed-off-by: adriancampo <[email protected]> * Refs #20130: async_get_type implementation Signed-off-by: adriancampo <[email protected]> * Refs #20130: Moved parser functions and reception checks Signed-off-by: adriancampo <[email protected]> * Refs #20130: Fixed typo Signed-off-by: adriancampo <[email protected]> * Refs #20130: Added functions to add and remove entries from maps. Change map keys to TypeIdentfierWithSize. Signed-off-by: adriancampo <[email protected]> * Refs #20130: Applied suggestions Signed-off-by: adriancampo <[email protected]> * Refs #20130: Changeds to instance_name. Signed-off-by: adriancampo <[email protected]> * Refs #20130: Applied suggestions Signed-off-by: adriancampo <[email protected]> * Refs #20130: Fixed copyright date Signed-off-by: adriancampo <[email protected]> * Refs #20130: Fixed warnings in release mode. Signed-off-by: adriancampo <[email protected]> * Refs #20130: Fix CI warning. Signed-off-by: adriancampo <[email protected]> * Refs #20130: Fix request instanceName check. Signed-off-by: adriancampo <[email protected]> * Refs #20130: Changes for smart_ptr ReaderProxyData and WriterProxyData. Signed-off-by: adriancampo <[email protected]> * Refs #20130: Removed use of private header for TypeLookupManager inside the public one for BuiltinProtocols. Signed-off-by: adriancampo <[email protected]> * Refs #20130: Fix for remove_async_get_type_callback. Signed-off-by: adriancampo <[email protected]> --------- Signed-off-by: adriancampo <[email protected]> New DynamicData API (#4189) * Refs #17138. New DynamicData API Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #17138. Applying suggestions Signed-off-by: Ricardo González Moreno <[email protected]> * Refs #17138. Applying suggestions Signed-off-by: Ricardo González Moreno <[email protected]> --------- Signed-off-by: Ricardo González Moreno <[email protected]> Regenerate types after rebase. Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Type Object integration (#4239) * Refs #19906: refactor annotation parameter value consistency method to deal with aliases Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19906: build wstring TypeIdentifiers Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19906: fix long double name using Fast DDS-Gen defined name Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19906: remove BuiltinAnnotations. Not required if not included in custom annotations sequence Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #19906: remove EquivalenceKindValue enum Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: support not applied annotation (extensibility/try_construct) Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix TypeIdentifier included in Minimal TypeObjects. Only explicit member flags Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: refactor bound consistency: unbounded collections have bound 0 Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix map key type identifier consistency Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: register indirect hash TypeIdentifier correctly Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: bitfields must have a name Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix minimal_from_complete TypeIdentifier method Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fixes for maps Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: update script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: update script Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: remove tests: build TypeObject from DynamicType is not going to be implemented. TypeInformation is private API Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types and ensure library builds Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: ensure examples build Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: remove tests related to type compatibility/evolution Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: avoid generating unnecessary TypeObjectSupport Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: use new transport headers Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix build DDS unit tests, including DDS Statistics Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: remove XTypes tests. Type evolution is not going to be supported yet and remote type discovery tests are being refactored Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: remove legacy ReturnCode and fix tests (pending DynamicTypesTests and RTPS Statistics tests) Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: use another approach for unit test building: mock DomainParticipantFactory. Apply to DDSSQLFilter tests as proof of concept Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types and register TypeObject support by default Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix tests compilation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix TypeObject tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix minimal annotation parameter sequence order. Fix minimal TypeIdentifier for map keys Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types and fixes after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix test in Release mode Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types after rebase in Fast DDS-Gen Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: linters Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix Python Bindings build Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix old API blackbox test compilation Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix build with TLS disabled Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types avoiding Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix windows max macro conflict in security tests Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types to avoid Windows warning Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: avoid code in test main method Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: apply review suggestions Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: regenerate types after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> * Refs #20129: fix CI warnings Signed-off-by: JLBuenoLopez-eProsima <[email protected]> --------- Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Fixes after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Regenerate types after rebase Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Fixes after rebase Signed-off-by: Ricardo González Moreno <[email protected]> Fixes for indirect hashes dependencies. (#4496) * Refs #20572: Fixes for indirect hashes dependencies. Signed-off-by: adriancampo <[email protected]> * Refs #20572: Applied suggestion. Added tests for build_plain_map_s_type_defn_inconsistencies. Signed-off-by: adriancampo <[email protected]> * Refs #20572: Fixes for plain_map_type_identifier_header_consistency. Signed-off-by: adriancampo <[email protected]> * Refs #20572: Changed get_type_dependencies methods and aliases equiv_kind as map components. Signed-off-by: adriancampo <[email protected]> * Refs #20572: Applied suggestions. Signed-off-by: adriancampo <[email protected]> * Refs #20572: Combined map consistency methods. Signed-off-by: adriancampo <[email protected]> * Refs #20572: Removed redundant check. Signed-off-by: adriancampo <[email protected]> --------- Signed-off-by: adriancampo <[email protected]> Regenerated files with last fastddsgen after rebase Signed-off-by: Ricardo González Moreno <[email protected]> Added Annotation dependencies (#4497) * Refs #20565: Added Annotation dependencies Signed-off-by: adriancampo <[email protected]> * Refs #20565: Applied suggestions. Added missing enum and bitmask dependencies. Signed-off-by: adriancampo <[email protected]> * Refs #20565: Typo. Signed-off-by: adriancampo <[email protected]> --------- Signed-off-by: adriancampo <[email protected]> DynamicType implementation (#4190) * Refs 17138. DynamicTypePtr as shared_ptr alias Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Solve singleton initialization issues. Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Updating DynamicTypeBuilder(Factory) Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Linter Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Refactor to follow standard guidelines Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixed annotations issues on TypeObject generation Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Natural conversion from DynamicTypeXXX to TypeDescriptor. Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixing Ubuntu build issues Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Use type singletons for builder singletons Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Tests fixes Signed-off-by: Miguel Barro <[email protected]> Refs 17138. doxygen and testing works Signed-off-by: Miguel Barro <[email protected]> Refs 17138. ScopeLogs ancillary Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing DynamicData enum interfaces Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing DynamicData bitmask interfaces Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fix auto-id numbering Signed-off-by: Miguel Barro <[email protected]> Refs 17138. force explicit DynamicData creation Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing DynamicData serialization, comparisson and copy Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing map implementation Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing struct implementation Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixing struct inheritance Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Trimming APIs Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixing union implementation Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixing xml profile testing Signed-off-by: Miguel Barro <[email protected]> Refs 17138. debugging recursive structures serialization Signed-off-by: Miguel Barro <[email protected]> Refs 17138. index management refactor and testing Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fix enum xml parsing Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing xml parsing tests Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing xml parsing tests Signed-off-by: Miguel Barro <[email protected]> Refs 17138. update serialization/deserialization to avoid runtime allocations Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing union default testing Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing xml parsing tests Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing bitsets ... Signed-off-by: Miguel Barro <[email protected]> Refs 17138. all tests fixed Signed-off-by: Miguel Barro <[email protected]> Refs 17138. moving dynamic tracker from runtime polymorphism to build time one Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing examples and blackbox testing Signed-off-by: Miguel Barro <[email protected]> Refs 17138. consistency fixes on type creation Signed-off-by: Miguel Barro <[email protected]> Refs 17138. ostream support for annotations Signed-off-by: Miguel Barro <[email protected]> Refs 17138. fixing dll export issues. New test binary to check them. Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Completing doxygen. Fixing CI issues. Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixing performance tests. Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Minor CI fixes Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Make create_xxx_builder() return constants only for static members. Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixing fastdds cli to work on python venv on windows Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixing doxygen. Signed-off-by: Miguel Barro <[email protected]> Refs 17138. CI API fixes Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Several test fixes Signed-off-by: Miguel Barro <[email protected]> Refs 17138. Fixing DynamicType…

JLBuenoLopez added this to the v3.0.0 milestone Jan 29, 2024

elianalf suggested changes Jan 31, 2024

View reviewed changes

include/fastdds/dds/domain/DomainParticipantFactory.hpp Outdated Show resolved Hide resolved

test/unittest/rtps/domain/RTPSDomainTests.cpp Show resolved Hide resolved

elianalf force-pushed the remove_deprecated_tests branch 7 times, most recently from 8bafb0a to 6a73744 Compare February 26, 2024 13:27

Base automatically changed from remove_deprecated_tests to 3.0.x-devel February 27, 2024 07:04

JLBuenoLopez force-pushed the 3.0.x-devel branch from 099aba7 to a05a97f Compare February 27, 2024 08:30

github-actions bot force-pushed the 3.0.x-devel branch from a05a97f to de717a1 Compare February 28, 2024 00:03

JLBuenoLopez force-pushed the 3.0.x-devel branch from ae91b4a to 645e17f Compare February 29, 2024 07:21

JLBuenoLopez force-pushed the feature/xmlparser-private branch from 7e735ea to a18a216 Compare February 29, 2024 10:53

elianalf mentioned this pull request Feb 29, 2024

Remove private XML parser APIs eProsima/Fast-DDS-docs#701

Merged

6 tasks

JLBuenoLopez force-pushed the 3.0.x-devel branch 2 times, most recently from 0ad3861 to d86ce21 Compare March 4, 2024 11:29

github-actions bot force-pushed the 3.0.x-devel branch from d86ce21 to 6f2e87e Compare March 5, 2024 00:03

JLBuenoLopez mentioned this pull request Mar 5, 2024

[20569] Migrate DLL API exporter and auto linkage to fastdds #4500

Merged

6 tasks

JLBuenoLopez force-pushed the feature/xmlparser-private branch 2 times, most recently from 66df78f to 8ce2354 Compare March 5, 2024 06:54

JLBuenoLopez force-pushed the 3.0.x-devel branch 3 times, most recently from fce9e0e to 4264a1f Compare March 6, 2024 08:39

JLBuenoLopez force-pushed the feature/xmlparser-private branch 2 times, most recently from e23b741 to 9dc7642 Compare March 6, 2024 13:32

JLBuenoLopez added 7 commits March 9, 2024 08:16

Refs #20301: add get_topic_attributes_from_profile API

30bd92d

Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]>

Refs #20301: get topic attributes from profile test

5fb7b6c

Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]>

Refs #20301: fixes after rebase

8d0d6e3

Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]>

Refs #20301: fix Windows warning

9d0917c

Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]>

Refs #20301: linters

1e40e53

Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]>

Refs #20301: fix Windows warning

bf982bb

Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]>

Refs #20301: fix memory leak

d4ca4ec

Signed-off-by: JLBuenoLopez-eProsima <[email protected]> Signed-off-by: EduPonz <[email protected]>

EduPonz added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Mar 9, 2024

Refs #20301: Run Github Windows CI on 3.0.x-devel PRs

ca9568d

Signed-off-by: EduPonz <[email protected]>

EduPonz force-pushed the feature/xmlparser-private branch from e77242f to ca9568d Compare March 9, 2024 07:23

EduPonz approved these changes Mar 9, 2024

View reviewed changes

EduPonz merged commit 3cb7df7 into 3.0.x-devel Mar 9, 2024
7 checks passed

EduPonz deleted the feature/xmlparser-private branch March 9, 2024 07:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20301] Make XML Parser API private #4318

[20301] Make XML Parser API private #4318

JLBuenoLopez commented Jan 29, 2024 •

edited by EduPonz

Loading

elianalf left a comment •

edited

Loading

JLBuenoLopez commented Feb 29, 2024

JLBuenoLopez commented Mar 1, 2024

JLBuenoLopez commented Mar 5, 2024

JLBuenoLopez commented Mar 5, 2024

[20301] Make XML Parser API private #4318

[20301] Make XML Parser API private #4318

Conversation

JLBuenoLopez commented Jan 29, 2024 • edited by EduPonz Loading

Description

Contributor Checklist

Reviewer Checklist

elianalf left a comment • edited Loading

Choose a reason for hiding this comment

JLBuenoLopez commented Feb 29, 2024

JLBuenoLopez commented Mar 1, 2024

JLBuenoLopez commented Mar 5, 2024

JLBuenoLopez commented Mar 5, 2024

JLBuenoLopez commented Jan 29, 2024 •

edited by EduPonz

Loading

elianalf left a comment •

edited

Loading