-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20120] TCPSendResources cleanup (backport #4300) #4511
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #20120: Remove unused include Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: TCP event call Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Sanitize transport Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Added tests and minor fixes Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Extended doxygen description and added to versions.md Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Add missing header Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Fix tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: After client-server decision making rebase, not working Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Update Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Fix for chaining-transports Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Add new channel connection status and tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: PR refactor, timed event deleted. cleanup on pdp unbinding Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Add unittests Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Fix deadlock Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Fix unittest Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Fix asio throwing exceptions Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Unnittest untab Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Apply suggestions Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Uncrustify Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Consider wan case + associated tests Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Remove versions.md update Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Fix rebasing wrong deletion Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Delete assert clause Signed-off-by: Jesus Perez <[email protected]> * Refs #20120: Apply suggestions Signed-off-by: EduPonz <[email protected]> --------- Signed-off-by: Jesus Perez <[email protected]> Signed-off-by: EduPonz <[email protected]> Co-authored-by: EduPonz <[email protected]> (cherry picked from commit fe11650) # Conflicts: # src/cpp/rtps/transport/TCPSenderResource.hpp # src/cpp/rtps/transport/TCPTransportInterface.cpp # src/cpp/rtps/transport/TCPTransportInterface.h # test/blackbox/common/BlackboxTestsTransportTCP.cpp # test/unittest/rtps/discovery/CMakeLists.txt # test/unittest/statistics/rtps/CMakeLists.txt # test/unittest/transport/CMakeLists.txt # test/unittest/transport/TCPv4Tests.cpp # test/unittest/transport/TCPv6Tests.cpp
Cherry-pick of fe11650 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
12 tasks
Closing this backport as long as 2.11.x is EOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #4300 done by Mergify.
Cherry-pick of fe11650 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com