Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20542] Nightly sanitizer job for Fast DDS supported branches #4524

Closed
wants to merge 1 commit into from

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Mar 6, 2024

Description

This PR splits and merges sections of the current sanitizers jobs, to achieve running a Fast DDS branches matrix nightly.

  • Both sanitizer workflows have been merged into a reusable parametrized sanitizer action.
  • Current sanitizer workflows use the reusable action for pull events and workflow dispatch.
  • New sanitizer nightly workflow has been created, which run as jobs the reusable parametrized sanitizer action for asan and tsan.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x
NOTE: MAKE SURE WHEN REVIEWING THE BACKPORTS THAT THE NIGHTLY WORKFLOW FILE IS REMOVED

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the needs-review PR that is ready to be reviewed label Mar 6, 2024
@JesusPoderoso JesusPoderoso added this to the v2.14.1 milestone Mar 6, 2024
@JesusPoderoso JesusPoderoso self-assigned this Mar 6, 2024
@JesusPoderoso JesusPoderoso force-pushed the hotfix/nightly_sanitizers branch from c429b9d to 9c652ed Compare March 6, 2024 18:56
@JesusPoderoso JesusPoderoso force-pushed the hotfix/nightly_sanitizers branch 5 times, most recently from 1f471cf to b5b99cc Compare March 14, 2024 16:08
@JesusPoderoso JesusPoderoso force-pushed the hotfix/nightly_sanitizers branch from 227de63 to f0b4816 Compare March 27, 2024 17:41
@JesusPoderoso JesusPoderoso requested a review from EduPonz March 27, 2024 17:41
@github-actions github-actions bot added the ci-pending PR which CI is running label Mar 27, 2024
@EduPonz
Copy link

EduPonz commented Apr 6, 2024

@EduPonz EduPonz closed this Apr 6, 2024
@EduPonz EduPonz deleted the hotfix/nightly_sanitizers branch April 17, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running needs-review PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants